Closed
Bug 984211
Opened 11 years ago
Closed 11 years ago
Fix up purplexpcom for bug 345123 and bug 967364
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Looks like we broke. This is a port of bug 984110, I don't fully understand these changes, but I think they're OK.
The actual changes this is fixing is for bug 345123 and bug 967364.
See the logs at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2082/steps/compile/logs/stdio
|
Assignee | |
Comment 1•11 years ago
|
||
This is a WIP because my build is failing and I need to go to bed. I hope it saves someone time tomorrow!
Attachment #8392012 -
Flags: feedback?(florian)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8392012 [details] [diff] [review]
WIP v1
Seems the correct thing to do.
Attachment #8392012 -
Flags: feedback?(florian) → feedback+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8392012 [details] [diff] [review]
WIP v1
Just got a successful build to complete.
Attachment #8392012 -
Flags: review?(florian)
|
|
||
Updated•11 years ago
|
Attachment #8392012 -
Flags: review?(florian)
Attachment #8392012 -
Flags: review+
Attachment #8392012 -
Flags: feedback+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•11 years ago
|
||
Oops, this is a purple patch, not c-c.
http://hg.mozilla.org/users/florian_queze.net/purple/rev/ddf4964591d5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•