984223 - Support H.264 hardware codec decoder on PlatformDecoder module for WebRTC

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P5)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

To achieve better performance on b2g platform, we should connect to media codec and use the hw decoder to avoid cpu usage.

Comment 1

[u459114]

Randy, is this bug target on integrate PlatformDecoder module inside webrtc? If that's the case, please change bug title to make it clearer

Comment 2

[Ivan Tsay (:ITsay)]

Not a blocker in 1.5 on the h264 hard support.

Comment 3

[Alfredo Yang (:alfredo)]

Hi Chris,
We plan to integrate the PlatformDecoderModule into webrtc so webrtc decoding can utilize the HW codec like OMX in bug 941302.
However in H.264 streaming, the resolution could change on the same stream and decoder should be able to handle it correctly. 
On codec part: OMX decoder should be able the handle this case via OMX interface [1]. FFMpeg seems also support it too [2].
On render part: when deocding, we check the every decoded imgae on the MediaDataDecoderCallback::Output(). Notify render if resolution changes.
Do you think that work? Thanks.

[1] http://e2e.ti.com/support/omap/f/849/t/218366.aspx
[2] http://trac.ffmpeg.org/ticket/1312

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Alfredo Yang from comment #3)
> We plan to integrate the PlatformDecoderModule into webrtc so webrtc
> decoding can utilize the HW codec like OMX in bug 941302.

Great!

> On render part: when deocding, we check the every decoded imgae on the
> MediaDataDecoderCallback::Output(). Notify render if resolution changes.

Do we need a notification? I don't think you do. I think the renderer can just check VideoData::mDisplay or VideoData::mImage->GetSize() or VideoData::mImage->GetPictureRect() to detect when the size of the image or the size at which it should be rendered changes? Right?

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: webrtc_platform_decoder

WIP

Comment 6

[Maire Reavy [:mreavy]]

It's an open question if a given platform HW implementation backing MediaCodec will be usable for WebRTC.  

We may also be able to leverage the VP8 MediaCodec work that Intel did for Android.

Comment 7

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.