984242 - Fix unused function warnings in widget/cocoa/nsChildView.mm

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-cocoa-warnings.patch

widget/cocoa/nsChildView.mm:230:1 [-Wunused-function] unused function 'NSRectToGeckoRect'                                                                                   
widget/cocoa/nsChildView.mm:239:1 [-Wunused-function] unused function 'ConvertGeckoRectToMacRect'

Bug 674373 replaced nsChildView::GetBounds()'s call to NSRectToGeckoRect() with CocoaPointsToDevPixels() in https://hg.mozilla.org/mozilla-central/rev/1d3de8da2508

Comment 1

[Josh Aas]

Comment on attachment 8392053 [details] [diff] [review]
fix-cocoa-warnings.patch

Review of attachment 8392053 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just delete that function and use this instead?

http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsCocoaUtils.h#282

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Josh Aas (Mozilla Corporation) from comment #1)
> Can we just delete that function and use this instead?
> 
> http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsCocoaUtils.h#282

I'm not sure I understand. No one is calling nsChildView.mm's (file) static function NSRectToGeckoRect() (which duplicated the nsCocoaUtils::NSRectToGeckoRect() function you linked to). nsChildView::GetBounds() used to call this NSRectToGeckoRect(), but that call was replaced with a call to CocoaPointsToDevPixels() in 2012:

https://hg.mozilla.org/mozilla-central/rev/1d3de8da2508#l7.76

Do you mean to replace nsChildView::GetBounds() call to CocoaPointsToDevPixels() with nsCocoaUtils::NSRectToGeckoRect()?

Comment 3

[Josh Aas]

Comment on attachment 8392053 [details] [diff] [review]
fix-cocoa-warnings.patch

Review of attachment 8392053 [details] [diff] [review]:
-----------------------------------------------------------------

My apologies, I was in a hurry and mis-read your patch the first time. Looks good to me.

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/792f1f76d7a6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/792f1f76d7a6