984269 - Rename nsDOMEventTargetHelper to mozilla::dom::EventTargetHelper or something

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsDOMEventTargetHelper doesn't represents standard DOM class. However, it's a base class of concrete classes derived from mozilla::dom::EventTarget. Therefore, for simpler code, it should be in mozilla::dom.

However, "Helper" sounds odd to me. It sounds like *Utils or something external class of EventTarget.

Is StubEventTarget or something better? (like nsStubMutationObserver)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I actually like the DOM prefix here, since we have also nsIEventTarget stuff which is all about threads and not about DOM Events.
And the class does have some utils stuff, so *Helper isn't so weird to me.

StubEventTarget might be ok too, though that indeed reminds more about StubMutationObserver
which is a really dummy class (no-op methods). The current nsDOMEventTargetHelper does quite a bit 
more than that. (ns)DOMEventTargetHelper has also the nice acronym, DETH.
So I'd probably call it mozilla::DOMEventTargetHelper.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Depending on nsEventStateManager -> mozilla::EventStateManager's patch.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8560fc7e2849

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8560fc7e2849

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed merge bustage between this and another change:
https://hg.mozilla.org/mozilla-central/rev/4941a2ac0786

Comment 6

[Dave Hylands [:dhylands]]

Fix bustage
https://hg.mozilla.org/integration/b2g-inbound/rev/8185dcc6b2dd

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #5)
> Fixed merge bustage between this and another change:
> https://hg.mozilla.org/mozilla-central/rev/4941a2ac0786

Thank you very much!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8185dcc6b2dd

Comment 9

[Firefox Commit Bot]

The following changesets are now in Firefox Nightly:

> 8560fc7e2849 Bug 984269 Rename nsDOMEventTargetHelper to mozilla::DOMEventTargetHelper r=smaug
> 4941a2ac0786 Fix merge bustage between changeset c8be375e0c41 (bug 988111) and changeset 8560fc7e2849 (bug 984269), merged (I think) in changeset 0ff6afce0133, on a CLOSED TREE.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central