984313 - [MADAI][Music] @2.25x assets update for Music

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Assets update.

Comment 1

[Helen Huang [:HHuang]]

Hi Dominic,
I need to update @2.25x assets to Music for 720p resolution device, could you help?

Comment 2

[Dominic Kuo [:dkuo]]

Yes, and will let you know if I have questions on the attached assets, thanks.

Comment 3

[Stephany Wilkes]

Thanks for taking this Dominic. How is this looking for landing?

Comment 4

[Dominic Kuo [:dkuo]]

(In reply to Stephany Wilkes from comment #3)
> Thanks for taking this Dominic. How is this looking for landing?

Sorry about not updating this bug, I should have a patch today and update later.

Comment 5

[Dominic Kuo [:dkuo]]

Attachment: Music screenshot after applied [e-mail]

Comment 6

[Dominic Kuo [:dkuo]]

Helen,

Please see attachment 8400418 [details], the rating stars seems different after applied [e-mail], also, I have found one missing image: [e-mail] which is under the folder in https://github.com/mozilla-b2g/gaia/blob/master/apps/music/style/images/ui/gradient.png, would you please check these two images and update the assets for us? thanks.

Comment 7

[Dominic Kuo [:dkuo]]

Attachment: patch

Comment 8

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Hi Dominic, thanks for your notice. The assets package is updated, [e-mail] has replaced with the correct one, and added [e-mail].

Comment 9

[Dominic Kuo [:dkuo]]

(In reply to Helen Huang from comment #8)
> Created attachment 8400500 [details]
> [e-mail]
> 
> Hi Dominic, thanks for your notice. The assets package is updated,
> [e-mail] has replaced with the correct one, and added
> [e-mail].

Thanks Helen! and I have updated these two images to my patch with the recompressed images, it should be ready for review.

Comment 10

[Dominic Kuo [:dkuo]]

Comment on attachment 8400421 [details] [review]
patch

Jim,

This is the 2.25x assets update for music app, it's mainly for the madai device and we are going to land it on master first, would you please review it? thanks.

Comment 11

[Jim Porter (:squib)]

Comment on attachment 8400421 [details] [review]
patch

Looks good to me! (I didn't run with the patch, though.)

Comment 12

[Dominic Kuo [:dkuo]]

Thanks Jim!

Landed on master: 39e4257932238105281aaadd0b041b757548b80b