984317 - Lightweight themes leave a sliver of the "back" button uncolored, with Australis and keyhole-style button on Linux

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Install a lightweight theme, e.g.
  https://addons.mozilla.org/en-US/firefox/addon/furfox-tail-twister/

 2. Inspect your "back" button at the left of URLbar

ACTUAL RESULTS: There's a sliver at the bottom-right of the back button that's unpainted, which looks quite odd.


I believe this is a new issue with Australis.

Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0
30.0a1 (2014-03-15)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[:Gijs (he/him)]

This looks like bug 477948 didn't quite get things right, but that's been backed out so the issue should be gone from 30 before it hits Aurora, as well as from Nightly.

(I'm assuming this is Linux-only, as that's how you've filed it)

Comment 3

[Brandon Cheng]

(In reply to :Gijs Kruitbosch from comment #2)
> This looks like bug 477948 didn't quite get things right, but that's been
> backed out so the issue should be gone from 30 before it hits Aurora, as
> well as from Nightly.
> 
> (I'm assuming this is Linux-only, as that's how you've filed it)

You would be right about that. I saw this same issue and it was created as a result of Adblock Plus stretching the navigation bar. Removing it from the toolbar fixes this issue.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to :Gijs Kruitbosch from comment #2)
> This looks like bug 477948 didn't quite get things right, but that's been
> backed out so the issue should be gone from 30 before it hits Aurora, as
> well as from Nightly.

I can confirm that my local mozilla-inbound build from today is unaffected (the back button is rectangular), so I can confirm that the issue seems to have gone away, per comment 2.

> (I'm assuming this is Linux-only, as that's how you've filed it)

I've only seen it on Linux (my local environment), so that's consistent with your assumption.

(In reply to Brandon Cheng from comment #3)
> I saw this same issue and it was created as a
> result of Adblock Plus stretching the navigation bar. Removing it from the
> toolbar fixes this issue.

That's not my experience. In my affected nightly, I see this in a fresh profile with no extensions at all, though the sliver is a bit smaller. Screenshot coming up.

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screenshot #2 (in fresh profile w/ no extensions)

Comment 6

[Justin Dolske [:Dolske]]

Odd, ISTR a similar bug on Windows or OSX from early in Australis. P2 assuming bug 477948 sticks.

Comment 7

[Daniel Holbert [:dholbert]]

Looks like the keyhole is back in, in Nightlies, and it works correctly now. (No sliver missing.)
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0
31.0a1 (2014-03-31)

Any objections to resolving this as FIXED by the latest patches from bug 477948 (bug 477948 comment 63, I think)?

Comment 8

[Mike de Boer [:mikedeboer]]

I think it's more probably fixed by bug 989701. Thanks for checking!

Resolving as per comment 7.

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to Mike de Boer [:mikedeboer] from comment #8)
> I think it's more probably fixed by bug 989701. Thanks for checking!

I don't think so; bug 989701 didn't make it into mozilla-central until 6 hours after Comment 7. (and in comment 7, my nightly from that morning was already fixed)

Comment 10

[Francesca Ciceri [:madamezou]]

[bugday-20140409]

Hi,

I was able to reproduce it in 30.0a1 (2014-03-15) on Linux x86_64 (Debian Sid).
I can confirm that the problem is no longer present in Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408030205 CSet: 8883360b1edb

[I'm not able to change the status to verified, so I'll just set the flag "status-firefox31 → verified"]

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Marking as verified as per comment 10.

Comment 12

[:Gijs (he/him)]

Marking fixed in 29/30 per bug 477948's status.

Comment 13

[Francesca Ciceri [:madamezou]]

[bugday-20140416]

I can confirm the fix in both latest beta and aurora.
I couldn't reproduce the problem on them, because before the updating of the patch in 477948 there wasn't the keyhole style in them on Linux, but I can confirm that:
1. they now sport the keyhole style buttons and
2. there's no sign of the uncolored sliver on the back button on them.

Verified on Debian Sid and in versions:
Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140414143035 CSet: 3a4f085a6398
Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140415004003 CSet: f14047fa8d63

Cheers,
Francesca