984326 - [B2G] [RIL] [CDMA] call waiting isn't working properly. The 2nd remote party cannot hear voice.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

cdma call waiting isn't working properly. 

STR:
1) A has a connection with B
2) C calls A, and A accepts it

Expected result:
C hears A

Actual result:
C doesn't hear A

This is a regression for Bug 881174. Sorry about that... ...

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Just discussed a possible solution with Vicamo, I'll provide a patch tomorrow.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

nominate as 1.4+ as it's a regression coming from 1.4+ bug 881174.

Comment 3

[Ken Chang[:kenkai]]

It is a 1.4+ issue.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: v1

The problem results from the fact:
In bug 881174, we added a callback of holdCall that enforces call state change.
However, in call waiting scenario, only one call exists and the call state should remain connected as expected.

As in 3way calling scenario, holdCall() and resumeCall() isn't allowed. The callback functions are never called of course. So I'd suggest simply removing those callback functions because 1) they shouldn't be there for cdma call waiting scenario and 2) they are never called in 3way call scenario.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Local tests pass. Let's wait for try result: https://tbpl.mozilla.org/?tree=Try&rev=5e95e2698f20

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/38a3545c5a6c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/38a3545c5a6c

Comment 8

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-aurora/rev/76b4ae5b1662