Closed Bug 984392 Opened 8 years ago Closed 8 years ago

submissions to balrog shouldn't silently fail

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(1 file)

I broke Fennec nightly submission to Balrog over in bug 984163 & 984166. It wasn't caught until days later because we set flunkOnFailure=False for all Balrog submissions. This is something we inherited from snippet uploads.

We should set the overall build as something other than green when Balrog submission fails, but we shouldn't do anything that would trigger a RETRY (or suggest to someone that it should be retried). Sheriffs, what do you think would be best for this? I was thinking EXCEPTION (purple), but I'm not sure whether or not that will end up with someone retriggering it most of the time.
Flags: needinfo?(ryanvm)
Flags: needinfo?(emorley)
We retrigger purples, yes. What would be wrong with this just causing the build to go red?
Flags: needinfo?(ryanvm)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #1)
> We retrigger purples, yes. What would be wrong with this just causing the
> build to go red?

I recall that we've been asked not to use red for infra issues in the past, because it confuses with code issues. That may be very old knowledge though, and I'm happy to use FAILURE/red if it works for you!
Signing server issues turn builds red, as do upload failures. Not sure what the difference would be.
Attached patch burn itSplinter Review
Attachment #8392233 - Flags: review?(rail)
Attachment #8392233 - Flags: review?(rail) → review+
Attachment #8392233 - Flags: checked-in+
Flags: needinfo?(emorley)
in production
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.