984463 - Update GeckoEditableListener constants to match IMEMessage constants

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Some  C++ constants in IMEMessage [1] have new values and the corresponding Java constants in GeckoEditableListener should be updated.

[1] http://mxr.mozilla.org/mozilla-central/source/widget/nsIWidget.h#486
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoEditable.java#49

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 984463 - Update GeckoEditableListener constants to match IMEMessage constants;

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8394287 [details] [diff] [review]
Bug 984463 - Update GeckoEditableListener constants to match IMEMessage constants;

r+ for the change. Sorry for the regression.

But I guess I or somebody may take same mistake in the future. Cannot check this at build time or debug assertion? If it's possible, could you do that? Detectable similar bug with permanent orange of automated test is really helpful.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

I think it'd be hard to have assertions, but I think we can write tests that will make use of these constants and make sure they work.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/9788a3f558e6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9788a3f558e6