Closed Bug 984463 Opened 6 years ago Closed 6 years ago

Update GeckoEditableListener constants to match IMEMessage constants

Categories

(Firefox for Android :: Keyboards and IME, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

Some  C++ constants in IMEMessage [1] have new values and the corresponding Java constants in GeckoEditableListener should be updated.

[1] http://mxr.mozilla.org/mozilla-central/source/widget/nsIWidget.h#486
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoEditable.java#49
Comment on attachment 8394287 [details] [diff] [review]
Bug 984463 - Update GeckoEditableListener constants to match IMEMessage constants;

r+ for the change. Sorry for the regression.

But I guess I or somebody may take same mistake in the future. Cannot check this at build time or debug assertion? If it's possible, could you do that? Detectable similar bug with permanent orange of automated test is really helpful.
Attachment #8394287 - Flags: review?(masayuki) → review+
I think it'd be hard to have assertions, but I think we can write tests that will make use of these constants and make sure they work.
Blocks: 977666
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9788a3f558e6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
You need to log in before you can comment on or make changes to this bug.