984482 - [B2G][Dialer] Switching between Call Log or Dialer keypad tabs to Contacts tab is not smooth

Status: RESOLVED DUPLICATE of bug 984618

(Core :: Graphics, defect, P1)

Description

[Natalya Kot [:nkot]]

Attachment: logcat

Description:
Switching from Call Log or dialer keypad to the Contacts tab is not smooth. Sometimes it freezes for 1-2 secs and then opens up Contacts tab partially loaded... see logcat and video for more info. 

Prerequisites:
*Have a few calls in the Call Log
*Have a few contacts in the Contacts

Repro Steps:
1) Updated Buri to BuildID: 20140317040204
2) Open Dialer
3) Switch between Call Log to Contacts back and forth multiple times 

Actual:
At some point Contacts tab doesn't open immediately or opens up not fully loaded

Expected:
The user is able to switch between tabs without any lags

Environmental Variables:
Device: Buri master (v1.4), Mozilla RIL
BuildID: 20140317040204
Gaia: 8f802237927c7d5e024fb7dca054dd5efef6b2e6
Gecko: 25cfa01ba054
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 2/2 devices, 60%
See attached logcat and video at http://youtu.be/iUkxaK9tOz4

Comment 1

[Jason Smith [:jsmith]]

Might be a graphics regression.

Does this happen on 1.3?

Comment 2

[Natalya Kot [:nkot]]

It doesn't happen on 1.3 

Easy way to check (alternative STR):
1. open Dialer
2. press&hold Call Log icon
3. while holding press Contacts icon --> Contacts icon gets highlighted
4. release Call Log icon --> Contacts icon freezes for a moment

On 1.3 the user is unable to press Contacts icon while holding Call Log icon therefore unable to replicate.

BuildID: 20140317004001
Gaia: 0ab8a9cbcef5f23cec904a3d7f7675e44de29951
Gecko: f824e9d91a2d
Version: 28.0

Comment 3

[Jason Smith [:jsmith]]

Does this reproduce with tiling disabled?

Comment 4

[Preeti Raghunath(:Preeti)]

Mike

Please review and reassign

Comment 5

[Jason Smith [:jsmith]]

Don't know why the regression keyword was removed here - this was already confirmed working on 1.3.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

There seems to be a few in this category of "order of magnitude performance regression with tiling".  If Mason could take a look, perhaps also (in the JS for now) setting layers.overzealous-gralloc-unlocking pref and seeing if it makes a difference.) it would help a lot.

Don't want to leave unassigned, so assigning to me, but Mason, if you look at this, please take the bug.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Attachment: dialer.MOV

I just tried reproducing on these revisions:

gaia: 5a66280d723afe92e90d809fbf9fbf16994fc437
gecko: 174518:cf485c48b52f

Attached is the video. I am unable to reproduce with make reference-workload-light. The only time I could get the stall is if I used two fingers to constantly button mash back and forth.

I also tested, and from what it looks, I was only able to reproduce when the user has imported some contacts and has never let the contacts database load. Interestingly, it actually performs much better with tiling than without.

This should not be a blocker due to comment 2. This does not reproduce on 1.3.

Comment 8

[Mason Chang [Inactive] [:mchang]]

Attachment: fresh_data.mov

Video showing lag after loading dialer right after a fresh make reference-workload. Upon restarting the phone, the large lag no longer occurs.

Comment 9

[Nicolas Silva [:nical]]

there are genlock failures in the logcat (and 0:26 in the video tiles showed something weird). This could be the same genlock errors that Chris is fixing in bug 984618

Comment 10

[Brogan Zumwalt [Inactive]]

Issue does NOT reproduce with Tiling disabled using STR in Comment 0. Issue listed with STR in Comment 2 DOES occur with Tiling disabled. 

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140320000349
Gaia: 53edbf08b0a750c31e8c6b2c20f2b1315b1412d1
Gecko: 9b482d6994fd
Version: 30.0a2
Firmware Version: v1.2-device.cfg


Issue reproduces with Tiling enabled, 2 outbound calls in call log, and 8 imported contacts from Facebook in Contacts using STR from Comment 0.

Comment 11

[Jason Smith [:jsmith]]

comment 2 is probably a different bug then. comment 0 is the bug on file here, so this is tiling regression.

Comment 12

[Jason Smith [:jsmith]]

I'm adding the dependency here to bug 984618 as the same genlock errors are seen in both bugs & bug 984618 has a patch. When that lands, we should retest this.

Comment 13

[No-Jun Park [:njpark]]

Attachment: 2014-03-27-12-52-26.png

This is reproducible on the latest master branch.  (see screenshot).
After the lag, waiting for a couple seconds and pressing the tab again shows the correct screen.  This seems to be triggered when two tabs are pressed alternately in 0.5 seconds repeatedly.

This is also reproducible when HWC is on or off. 

│ Gaia      9da1b9c11bf518bce882be305ae121c44c5d1e05                         │
│ Gecko     https://hg.mozilla.org/mozilla-central/rev/9afe2a1145bd          │
│ BuildID   20140327040202                                                   │
│ Version   31.0a1

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

No-Jun, which STR are you using when testing?  There is one from Comment 0, one from Comment 2, one from Comment 7, although admittedly, they are all similar.

Comment 15

[No-Jun Park [:njpark]]

(In reply to Milan Sreckovic [:milan] from comment #14)
> No-Jun, which STR are you using when testing?  There is one from Comment 0,
> one from Comment 2, one from Comment 7, although admittedly, they are all
> similar.

Oh, the original one, Comment 0.  Sorry for not being clear.

Comment 16

[Jason Smith [:jsmith]]

Can we get a video & a logcat of this reproducing on the latest trunk?

Comment 17

[Josh Schmitt [Joshs]]

Based on comment 11, comment 2 and comment 0 are separate issues, I am NOT able to repro comment 0 issue on latest 1.5 Buri build (3/27/14) though i can get it to repro on older build 1.4 (20140320000349). Comment 2 issue is still reproducible on the latest 1.5 buri build.

Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140327061550
Gaia: 287195d1fed2e6c883745d7091a4c05e56c4dbb7
Gecko: bb4dd9872236
Version: 31.0a1
Firmware Version: V1.2-device.cfg