Closed Bug 984497 Opened 6 years ago Closed 6 years ago
Powers more and change Special Power usage to deal with Window on Web IDL bindings
No description provided.
Attachment #8392341 - Flags: review?(bzbarsky)
Comment on attachment 8392341 [details] [diff] [review] v1 > +++ b/content/media/webspeech/synth/test/common.js This change worries me. Reloading a test in the test harness seems like it would do weird stuff. We should probably instead run those tests in a subframe that's not loaded until a pushPrefEnv for the pref finishes. >+++ b/dom/tests/mochitest/bugs/test_bug397571.html Why can this not use SpecialPowers.DOMWindowUtils? Document, please. >+++ b/js/xpconnect/tests/mochitest/test_bug870423.html Why is this change ok? What in this patch makes the instanceof there work? The rest looks good, but r- for the webspeech bits...
Attachment #8392341 - Flags: review?(bzbarsky) → review-
(In reply to Boris Zbarsky [:bz] from comment #1) > >+++ b/dom/tests/mochitest/bugs/test_bug397571.html > > Why can this not use SpecialPowers.DOMWindowUtils? Document, please. It actually can. > >+++ b/js/xpconnect/tests/mochitest/test_bug870423.html > > Why is this change ok? What in this patch makes the instanceof there work? It's not, it ended up in the wrong patch.
Comment on attachment 8400087 [details] [diff] [review] v1.1 r=me
Attachment #8400087 - Flags: review?(bzbarsky) → review+
BTW, had to remove a part of js/xpconnect/tests/chrome/test_doublewrappedcompartments.xul, Bobby approved that earlier but I forgot to integrate it in this patch.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.