984528 - Rename manifestdestiny -> manifestparser

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

The term "manifest destiny" (the name of our library for processing test manifests) is actually rather offensive to many native americans. It refers to a philosophy that was used to justify genocide in the 19th century:

http://en.wikipedia.org/wiki/Manifest_destiny#Native_Americans

I know that the term has had different uses throughout the last several hundred years, not all of them that offensive. I'm sure there was no malicious intent behind the original naming. Still, I can't help but feel that we should rename the package to "mozmanifest" to avoid potentially upsetting people. Even from a pragmatic perspective, the arguments around this stuff tend to be pretty unconstructive and I'd rather nip the possibility of one at the bud. 

Also, the import name for the library is "manifestparser", so it would make sense if the project name matched that.

This has been generally approved of by the other mozbase maintainers. There's not really that much to be done here:

1. Rename manifestdestiny -> manifestparser in setup.py
2. Update documentation
3. Create a new project on pypi called manifestparser

We can keep manifestdestiny around indefinitely for backwards compatibility. Projects can update the dependency at their own pace.

Comment 1

[William Lachance (:wlach)]

Decided it was time to actually do this. Did up a patch, here's a try run:

https://tbpl.mozilla.org/?tree=Try&rev=ecc01663b1db

Comment 2

[William Lachance (:wlach)]

That didn't work, retrying:

https://tbpl.mozilla.org/?tree=Try&rev=a0776fce4423

Comment 3

[William Lachance (:wlach)]

Attachment: Patch

Ok, this passes try so I guess it's good for review.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8436073 [details] [diff] [review]
Patch

Review of attachment 8436073 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but the path is still testing/mozbase/manifestdestiny.. shouldn't that be changed too?

Comment 5

[William Lachance (:wlach)]

(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Comment on attachment 8436073 [details] [diff] [review]
> Patch
> 
> Review of attachment 8436073 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good, but the path is still testing/mozbase/manifestdestiny..
> shouldn't that be changed too?

Where? As far as I can tell I moved the directory from manifestdestiny to manifestparser...

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8436073 [details] [diff] [review]
Patch

Review of attachment 8436073 [details] [diff] [review]:
-----------------------------------------------------------------

Oh sorry, I think you're right. In the diff view it still says 'manifestdestiny' in the path names which confused me. But in the review view it looks like it was changed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So for that upcoming release, and with an eye on PyPI, it will become a new product, right? Shouldn't we reset the version numbers then?

Comment 8

[Andrew Halberstadt [:ahal]]

I think that would be confusing. I don't see any harm in continuing with the version we have.

Comment 9

[William Lachance (:wlach)]

This can go in now, I think. See try run: 
https://tbpl.mozilla.org/?tree=Try&rev=a0776fce4423

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This is bitrotted. Please rebase.

Comment 11

[William Lachance (:wlach)]

Attachment: Update for bitrot

Comment 12

[William Lachance (:wlach)]

Updated, conflict was in a comment. Should work now.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1737dfde961b

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1737dfde961b

Comment 15

[Ed Morley [:emorley]]

I believe this was the cause of the various build timeouts seen in the last 12 hours, due to needing a clobber. eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41500834&tree=Mozilla-Central
https://tbpl.mozilla.org/php/getParsedLog.php?id=41500443&tree=Mozilla-Central
https://tbpl.mozilla.org/php/getParsedLog.php?id=41500524&tree=Mozilla-Central

I've updated the CLOBBER file since it won't hurt either way:
remote:   https://hg.mozilla.org/mozilla-central/rev/18c21532848a