984584 - [B2G][Dialer] Contacts phone numbers highlighted red when viewing from Call Log list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Tony Nguyen]

Attachment: screenshot

Description:
When viewing a contact information from the Call Log list, the phone numbers will be highlighted in red. 

Prerequisite: 
-Have a contact saved
-Have a call already made from/to saved contact (so Call Log has some data)

Repro Steps:
1) Updated Buri to BuildID: 20140317004001
2) Navigate to Dialer app > Call Log
3) Tap on a call in Call Log list
4) View Contact information

Actual Result:
Contact phone number is highlighted in red text similar to a missed call 

Expected Result:
Contact phone number is colored black

Environmental Variables:
Device: Buri v1.3 mozRIL
BuildID: 20140317004001
Gaia: 0ab8a9cbcef5f23cec904a3d7f7675e44de29951
Gecko: f824e9d91a2d
Version: 28.0
v1.2-device.cfg

Attached: screenshot

Comment 1

[Maria Angeles Oteo (:oteo)]

Strange issue... setting ni to Vicky to confirm that that is not the correct color.

Comment 2

[Victoria Gerchinhoren [:vicky]]

Hi,

This is, from my understanding, the correct behaviour. When you go from call log to a contact's detail you'll have the number the contact called from highlighted in a color, to indicate which number he/she called from and distinguish it from the rest of numbers from the same contact.

When that entry you tap on is a recieved or made call it will be orange, but if the call was missed it will be red, because this information screen comes from the Call log.

Comment 3

[Noemí Freire (:noemi)]

Hi,

After checking with the following scenarios:

Today's (4/1) master build:
Device: Hamachi
BuildId: 20140401065548
Gaia: f9a44b5
Gecko: f1b5b05
Platform version: 31.0a1

Today's (4/1) v1.3 build:
Device: Hamachi
BuildId: 20140401060114
Gaia: 24f562f
Gecko: f7ce6e6
Platform version: 28.0

It doesn't matter if it is a call already made from/to saved contact or a missed call, the phone number always appears with the same color. Please find attached screenshots showing the current behavior on v1.3 (v1.3.png) and master (master.png) branches.

The approach explained by Victoria in comment 2 could be addressed as part of the Visual Refresh stuff, for this reason blocking bug 950765 (meta bug gathering all the VR related to contacts app). Asking Victoria for the needed visual material for covering this task. Thanks!

Comment 4

[Noemí Freire (:noemi)]

Attachment: master.png

Comment 5

[Noemí Freire (:noemi)]

Attachment: v1.3.png

Comment 6

[Victoria Gerchinhoren [:vicky]]

Please, find attached the expected look of the contact's phone number in the contact details depending on the case. We currently set that the number is highlighted in orange, and due to the refresh the number should be highlighted in a specific kind of blue. 

Thanks.

Comment 7

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Spec for fixing number coloring issue

Comment 8

[Michał Budzyński (:michalbe)]

WIP patch [1] prepared, it just needs tests and will be ready to r?. Etienne, since Anthony is on PTO, who will be good reviewer for this?

[1] https://github.com/michalbe/gaia/commit/1e623cb817fc872bcb9c87543cd6061ad194dd70

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to Michał Budzyński (:michalbe) from comment #8)
> WIP patch [1] prepared, it just needs tests and will be ready to r?.
> Etienne, since Anthony is on PTO, who will be good reviewer for this?

I'll review the dialer part, but you'll still need a contact peer.

Comment 10

[Michał Budzyński (:michalbe)]

Attachment: Final Patch

Comment 11

[Michał Budzyński (:michalbe)]

Thank Etienne, patch ready for review. 

Ben, could you please review the Contacts part? Thanks in advance!

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8417510 [details] [review]
Final Patch

awesome, r=me for the dialer part!

Comment 13

[Michał Budzyński (:michalbe)]

Than you Etienne for very valuable tips on my tests, updating them now.

Comment 14

[Michał Budzyński (:michalbe)]

Updated, waiting for Ben's r?.

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

Code looks good.  When I try it on my device with |make reference-workload-light|, though, the number for non-missed calls is the normal blue color.  Shouldn't it be orange according to comment 2?

Comment 16

[Michał Budzyński (:michalbe)]

According to visuals in comment 7 the non-missed phone numbers are blue.

Comment 17

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8417510 [details] [review]
Final Patch

Verified the missed call shows up in red.  And as pointed out the visual spec does in fact say blue. r=me

Thanks.  Great work!

Comment 18

[Michał Budzyński (:michalbe)]

Thanks Ben! I fixed tests where you asked me to and merged with master: https://github.com/mozilla-b2g/gaia/commit/9586d1233ee28b96a5bb5dc88a6c183a493055f7

Comment 19

[Victoria Gerchinhoren [:vicky]]

Can you please provide screenshot and request UI review? There's no way we can say it's solved. As far as I see in the current build, this is bad solved.

Comment 20

[Noemí Freire (:noemi)]

Per comment 19 marking this bug as REOPENED.

Comment 21

[Michał Budzyński (:michalbe)]

:vicky what exactly do you mean? What is wrong with the current build? It works exactly as requested in your Comment 7 (just the highlighting of the number).

Comment 22

[Victoria Gerchinhoren [:vicky]]

(In reply to Michał Budzyński (:michalbe) from comment #21)
> :vicky what exactly do you mean? What is wrong with the current build? It
> works exactly as requested in your Comment 7 (just the highlighting of the
> number).

Michal, yes the behaviour and the colors are ok, but how it is specified, the font style is italic and the weight of it is "Regular". As I see it now on the phone, it is bold. It should be Style: Italic and weight: 400.

Let me know if there's something else you need me to clarify.

Comment 23

[Michał Budzyński (:michalbe)]

Attachment: screen.jpg

:vicky, sorry for misunderstanding, I hope this is exactly what you meant before.

Comment 24

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421084 [details]
screen.jpg

Thanks!

Comment 25

[Michał Budzyński (:michalbe)]

Landed in master - https://github.com/mozilla-b2g/gaia/commit/d8a2a6c8db3e175c4d05e365e8de89ec0889d2bc

:vikcy, can I mark this bug as 'FIXED' now?