984632 - [Camera] Zoom slider too close from the capture buttons on landscape orientation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

The zoom slider is too close from the capture buttons on landscape orientation. See attached images

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: zoomSliderHud.png

Comment 2

[Diego Marcos [:dmarcos]]

Attachment: zoomSliderControls.png

Comment 3

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (camera-new-features)

Amy: Flagging you for ui-review. Now that the new Camera controls have landed, can you please verify if the Zoom Bar positioning/sizing is correct? Thanks!

Comment 4

[Justin D'Arcangelo [:justindarc]]

Amy: I just realized, you may need to add my fork as a git remote to look at this patch:

To add my remote fork, run:
git remote add justindarc https://github.com/justindarc/gaia.git

Then from there, it is business as usual:
git fetch justindarc
git checkout justindarc/bug984632
make install-gaia APP=camera

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8393044 [details] [review]
pull-request (camera-new-features)

r+. Note though that because of the rotation I can't visualize how this CSS change will actually affect what is on the screen.  If you attach a new screenshot that Amy can contrast with Diego's screenshot, that might expidite UX review. Probably no need to actually flash gaia to try out a minor change like this.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Attachment: screenshot with patch applied

Amy: Here is a screenshot with the patch applied as per djf's request. Please let me know if this positioning looks correct and I can go ahead and land the patch. Thanks!

Comment 7

[Justin D'Arcangelo [:justindarc]]

Attachment: screenshot with patch applied

Comment 8

[Amy Lee [:amylee] UX]

Comment on attachment 8393117 [details]
screenshot with patch applied

Looks good!

Comment 9

[Tiffanie Shakespeare [:tif]]

Looking at Justin's patch, there were a couple of things I noticed with the zoom bar and rotating the phone. Should I include those here or file a new bug?

Comment 10

[Justin D'Arcangelo [:justindarc]]

Tiffanie: If it is unrelated to the closeness to the capture button, please file a new bug. I'm going to be closing this since the patch just landed to resolve this issue. Thanks!

Comment 11

[Justin D'Arcangelo [:justindarc]]

Landed on camera-new-features:

https://github.com/mozilla-b2g/gaia/commit/583de1d131ea3e2d36ccb305deb014bf4fb3be35

Comment 12

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8393117 [details]
screenshot with patch applied

looked at fix on camera-new-features: zoom bar does not overlap the camera buttons

Comment 13

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 14

[sarsenyev]

The issue is no longer reproduces on the latest 1.4 and master build
Zoom slider is not close to "shutter" icon in landscape mode

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140410000201
Gaia: 9b2da43dfee3792cd311ae55f0b06272313208f0
Gecko: 9d9ead7d6afa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140410040201
Gaia: 9d0b1bdf746823a94b13e6574c1d8304dc584763
Gecko: 690c810c8e3e
Version: 31.0a1
Firmware Version: v1.2-device.cfg