98468 - Sample value for emailregexp allows empty user names

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P1)

Description

[alex]

In defparams.pl, the description of the emailregexp parameter is given as 
follows:
'This defines the regexp to use for legal email addresses.  The default tries to 
match fully qualified email addresses.  Another popular value to put here is 
<tt>^[^@]*$</tt>, which means "local usernames, no @ allowed.'

If you use the given sample value for emailregexp, Bugzilla will accept an empty 
string as a valid user name.

Also note the missing quote mark at the end of the string.

I recommend changing the description to:
'This defines the regexp to use for legal email addresses.  The default tries to 
match fully qualified email addresses.  Another popular value to put here is 
<tt>^[^@]+$</tt>, which means "local usernames, no @ allowed."'

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

Comment 2

[Dave Miller [:justdave]]

I noticed the default emailregexp for a full email address had exactly the same 
problem.  This patch fixes both.

Comment 3

[Jacob Steenhagen]

Comment on attachment 48400 [details] [diff] [review]
Patch v1

r=jake
No second review required.

Comment 4

[Dave Miller [:justdave]]

checked in.