984740 - When calling notifyChange, don't request an upload sync if the caller is Sync

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: When calling notifyChange, don't request an upload sync if the caller is Sync.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8392678 [details] [diff] [review]
When calling notifyChange, don't request an upload sync if the caller is Sync.

Review of attachment 8392678 [details] [diff] [review]:
-----------------------------------------------------------------

A trivial -- if repetitive -- fix. isCallerSync is copypasta'ed from TransactionalProvider, in the hope of future refactorings.

I elected to use a descriptive final variable rather than inlining the call-with-not, because boolean arguments are the devil.

I haven't tested this yet, but this should entirely eliminate the immediate double-bounce syncs that we've been seeing for two years.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8392678 [details] [diff] [review]
When calling notifyChange, don't request an upload sync if the caller is Sync.

Review of attachment 8392678 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  Consider factoring out a local |maybeNotifyChange(url)| that does the Sync check?  Hard to prevent future callers missing that and instead calling the ContentResolver's |notifyChange|.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/9d2991a00b4d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d2991a00b4d