Closed
Bug 984788
Opened 11 years ago
Closed 11 years ago
Convert legacy uses of promise.js to Promise.jsm
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
|
7.92 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
This bug converts existing imports of the legacy promise.js module to Promise.jsm, in those instances where there is no need to make further changes.
|
Assignee | |
Comment 1•11 years ago
|
||
This is a mechanical tree-wide change, requesting a rubber-stamp from David.
Individual tryserver runs were green, new coalesced run here:
https://tbpl.mozilla.org/?tree=Try&rev=bdf244f1a2ef
Attachment #8392770 -
Flags: review?(dteller)
|
|
Assignee | |
Comment 2•11 years ago
|
||
This tree-wide legacy module conversion is limited to the cases where it did not cause test failures, thus it should be good to go with a rubber-stamp from David. I'm CC'ing people who worked on the affected code in case they have any comment.
Blocks: 856878
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8392770 [details] [diff] [review]
The patch
Review of attachment 8392770 [details] [diff] [review]:
-----------------------------------------------------------------
rubberstamp+
Attachment #8392770 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•