984789 - FileHandle: Eliminate nsIFileStorage

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8410052 [details] [diff] [review]
patch

Review of attachment 8410052 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: dom/filehandle/FileHandle.cpp
@@ +69,5 @@
>  FileHandle::~FileHandle()
>  {
>  }
>  
> +#if 0

I'd rather not leave #if 0 code around. Let's just remove it for now, we can always get it back later.

::: dom/indexedDB/IDBFileHandle.cpp
@@ +5,5 @@
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "IDBFileHandle.h"
>  
> +#include "mozilla/Assertions.h"

You already added this to the .h

@@ +40,5 @@
>    : FileHandle(aOwner)
>  {
>  }
>  
> +NS_IMPL_CYCLE_COLLECTION_INHERITED_1(IDBFileHandle, FileHandle, mDatabase)

Just FYI, no need for the _1 now

::: dom/quota/QuotaManager.cpp
@@ +2415,5 @@
>              indexes.AppendElement(index);
>            }
>          }
>  
> +        StorageMatcher<nsTArray<nsCOMPtr<nsIOfflineStorage> > > liveStorages;

Nit: >>>, below too.

Comment 3

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef60f8aa9a01

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef60f8aa9a01