984800 - [MADAI][Contacts] @2.25x assets update for Contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Assets updates.

Comment 1

[Helen Huang [:HHuang]]

Hi,
I would like to update 2.25x assets to Contacts for Madai, could someone help with it?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 17746

Didn't add the twitter image since we are in the process of removing it.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

No tests for this PR since is just an update of binary files.

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8398407 [details] [review]
Pointer to PR 17746

thanks

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/c1a3861333414b85978f0ca2428f0af499a3d6bc

Thanks everyone.

Comment 6

[Gabriele Svelto [:gsvelto]]

(In reply to Francisco Jordano [:arcturus] from comment #5)
> Landed:
> 
> https://github.com/mozilla-b2g/gaia/commit/
> c1a3861333414b85978f0ca2428f0af499a3d6bc

Francisco I've noticed two issues with this commit.

The gmail icon is called [e-mail] and not [e-mail], that should be fixed.

The new images haven't been re-compressed with the png_recompress.sh tool available in gaia, doing so saves significant space (a ~60% reduction in size). You can compress those images by running the following command from gaia's root directory (once you have corrected the gmail icon name):

./tools/png_recompress.sh -v apps/communications/contacts/style/images/*2.25x.png

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi Gabriele, thanks for the heads up, I'm backing out this commit and following the correct process.

(my first time mistake, won't happen again ;))

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Francisco Jordano [:arcturus] from comment #7)
> Hi Gabriele, thanks for the heads up, I'm backing out this commit and
> following the correct process.
> 
> (my first time mistake, won't happen again ;))

No problem, the compression stuff is not a functional issue so I normally do it in follow-ups but the icon name is an actual bug as the correct asset won't be displayed.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 17760

Now renamed the gmail one and applied the optimizer.

Comment 10

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8398559 [details] [review]
Pointer to PR 17760

Perfect!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Re-landed in master ;)

https://github.com/mozilla-b2g/gaia/commit/b8bb3e2e79c3c1b89631a565a21b5d8b782aaf3f