984804 - Open All in Tabs not highlighted on keyboard selection; weak change on mouse-over

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[B.J. Herbison]

I regularly open all bookmarks with the keyboard, and recently I've lost the feedback that I've selected the correct entry.

With Nightly 31 (2014-03-17):
1) Click to open the Bookmarks popup.
2) With arrow keys move down to Show All Bookmarks.
3) Move the mouse over Show All Bookmarks.
4) With arrow keys move up to Recently Bookmarked, over, down to Open All in Tabs.
5) Move the mouse over Open All in Tabs.

Expected:
2&4) Visual difference in Show All Bookmarks/Open All in Tabs when selecting with arrow keys.
3&5) Visual difference when selecting with mouse.

Actual:
2&4) No noticeable change when select with the arrow keys.
3&5) Some difference when selecting with the mouse, but the difference is much less noticeable than the change on the other items in the menu.

Tested with Ubuntu and Windows. I tried an old install of 2014-03-07 and there was a difference in Open All in Tabs with keyboard activation.

Comment 1

[:Gijs (he/him)]

Stephen, can we make the hover/focus state for the footers be more different from the plain state than it is now? I kind of agree that the change is very slight.

I need to look at the arrow keys issue, that's just kind of strange. :-\

Comment 2

[:Gijs (he/him)]

Attachment: highlight footer more strongly, make it work for keyboard nav in the menu,

Comment 3

[:Gijs (he/him)]

Comment on attachment 8393239 [details] [diff] [review]
highlight footer more strongly, make it work for keyboard nav in the menu,

Stephen, does this change seem OK to you?

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 8393239 [details] [diff] [review]
highlight footer more strongly, make it work for keyboard nav in the menu,

Review of attachment 8393239 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8393239 [details] [diff] [review]
highlight footer more strongly, make it work for keyboard nav in the menu,

LGTM too (Stephen's ui-r+ was most important here).

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/72fadd2a164f

Comment 7

[:Gijs (he/him)]

Comment on attachment 8393239 [details] [diff] [review]
highlight footer more strongly, make it work for keyboard nav in the menu,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: bookmarks menu doesn't behave consistently when using the keyboard instead of the mouse, and its hover/active states are very hard to discern.
Testing completed (on m-c, etc.): soon on m-c!
Risk to taking this patch (and alternatives if risky): very low, CSS-only change to footers
String or IDL/UUID changes made by this patch: none

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72fadd2a164f

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43d53eb54223
https://hg.mozilla.org/releases/mozilla-beta/rev/a87f2be01c6e

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue using old Nightly (2014-03-17) on Windows 7 64bit and Windows 8.1 64bit. Verified as fixed on Firefox 29.0.1 RC, Firefox 30 beta 2 and latest Aurora.