Closed
Bug 984892
Opened 12 years ago
Closed 12 years ago
Lazy load library does not cache fragments
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crdlc, Assigned: crdlc)
Details
Attachments
(1 file)
I think that this is not the correct and expected behavior but if it should work so, then I will close the bug
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
Thanks guys
Attachment #8392867 -
Flags: review?(jmcf)
Attachment #8392867 -
Flags: review?(21)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8392867 -
Flags: review?(jmcf) → review?(kgrandon)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8392867 [details]
Patch v1
Let's ask Kevin as he wrote this file.
Attachment #8392867 -
Flags: review?(21) → review?(kgrandon)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8392867 -
Flags: review?(kgrandon)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8392867 [details]
Patch v1
Was this causing a bug or anything? I guess I'm not sure if caching is the right terminology here as we would just be saving an empty iteration over the child nodelist. This is possibly a performance win, so R+ from me.
Attachment #8392867 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
I haven't seen any bug but I realized that each time that I added a fragment to DOM there was a reflow and I thought "but if this fragment was already rendered" and I started looking into the lazy load lib and I saw that fragments are indexed by id but recovered by node. If you are comfortable we can land on master.
|
|
||
Comment 5•12 years ago
|
||
Nice! Sounds good to me: https://github.com/mozilla-b2g/gaia/commit/94e4c64a74916ce42b68ece0dd705bb039820679
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•