984900 - Places async transactions: Implement "sort by name" ui command

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Another easy conversion.

Comment 1

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Hi Mano, can you explain this bug a little more? I'd like to figure out if we should be doing some QA to verify this once it's fixed, and if so, what it means and how to verify it. Thanks!

Comment 2

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Same answer as in bug 984898.

Comment 3

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Attachment: patch

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8402607 [details] [diff] [review]
patch

Review of attachment 8402607 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/content/controller.js
@@ +293,5 @@
>      case "placesCmd_reload":
>        this.reloadSelectedLivemark();
>        break;
>      case "placesCmd_sortBy:name":
> +      Task.spawn(this.sortFolderByName.bind(this)).then(null, Cu.reportError);

as I said in the other bug, should be enough to this.sortFolderByName().then(...

Comment 5

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

https://hg.mozilla.org/integration/fx-team/rev/f155947ac140

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f155947ac140

Comment 7

[u279076]

Tagged [qa-] as per comment 2.