Closed Bug 984900 Opened 9 years ago Closed 9 years ago

Places async transactions: Implement "sort by name" ui command

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 31

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Whiteboard: p=2 s=it-31c-30a-29b.2 [qa-] )

Attachments

(1 file)

patch
3.07 KB, patch
mak
: review+
Details | Diff | Splinter Review 
Another easy conversion.
Assignee: nobody → mano
Blocks: fxdesktoptriage
Blocks: fxdesktopbacklog
No longer blocks: fxdesktoptriage
Whiteboard: p=0
Status: NEW → ASSIGNED
Whiteboard: p=0 → p=2 s=it-31c-30a-29b.2
Hi Mano, can you explain this bug a little more? I'd like to figure out if we should be doing some QA to verify this once it's fixed, and if so, what it means and how to verify it. Thanks!
Flags: needinfo?(mano)
Whiteboard: p=2 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2 [qa?]
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Same answer as in bug 984898.
Flags: needinfo?(mano)
Attached patch patch — — Splinter Review 

        Attachment #8402607 -
        Flags: review?(mak77)

    
    

    
  
Comment on attachment 8402607 [details] [diff] [review]
patch

Review of attachment 8402607 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/content/controller.js
@@ +293,5 @@
>      case "placesCmd_reload":
>        this.reloadSelectedLivemark();
>        break;
>      case "placesCmd_sortBy:name":
> +      Task.spawn(this.sortFolderByName.bind(this)).then(null, Cu.reportError);

as I said in the other bug, should be enough to this.sortFolderByName().then(...

        Attachment #8402607 -
        Flags: review?(mak77) → review+

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/f155947ac140
Target Milestone: --- → Firefox 31

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f155947ac140
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Tagged [qa-] as per comment 2.
Whiteboard: p=2 s=it-31c-30a-29b.2 [qa?] → p=2 s=it-31c-30a-29b.2 [qa-]
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.