984969 - Delay Browser Toolbox connection until load event

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The Browser Toolbox's main script file opens a connection at the top-level of the file[1].

This is okay currently, but in bug 797639, the transport will be refactored to use async streams, so this immediate connection dispatch stream events to the event queue.

The startup precompilation tool runs all these JS files, so this means it triggers the immediate connection here.  Once these future transport changes land, this tool ends up with event queue that causes it to segfault.

The easy fix is to just wait for load here, so the tool doesn't attempt network activity.

[1]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/framework/toolbox-process-window.js#25-32

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Only connect from Browser Toolbox after load

Try: https://tbpl.mozilla.org/?tree=Try&rev=b7cc8c8c5954

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8392952 [details] [diff] [review]
Only connect from Browser Toolbox after load

Review of attachment 8392952 [details] [diff] [review]:
-----------------------------------------------------------------

I'm secretly wishing this also fixes bug 945663.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 8392952 [details] [diff] [review]
> Only connect from Browser Toolbox after load
> 
> Review of attachment 8392952 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm secretly wishing this also fixes bug 945663.

That would be nice!  I can't reproduce that one, so maybe someone else will be able to tell if it's fixed...

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/198a62be50cf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/198a62be50cf