985016 - [B2G][Camera] Z-Index of Zoom Bar is incorrect

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Justin D'Arcangelo [:justindarc]]

Attachment: Screenshot

The z-index of the Zoom Bar is too high and overlaps the Settings menu when open. See attached screenshot.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (camera-new-features)

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8392999 [details] [review]
pull-request (camera-new-features)

Thanks for finding and fixing this.

Please go ahead and land this. 

In addition, it would be great if someone (like you) could take a big-picture look at z-index issues throughout the app and make a list of all the things we display and what their z-indexes should be.  I assume that we currently have dependencies on the order in which views are instantiated and I think it would be better if we made the stacking order explicit with z indexes for everything.  Of course, fixing bugs probably takes priority over something like this.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on camera-new-features:

https://github.com/mozilla-b2g/gaia/commit/ff8253f5a5e88bf28076a35a347e357cc997a901

Comment 4

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530