985052 - Firefox no longer seems to be respecting the browser.sessionstore.restore_pinned_tabs_on_demand preference

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I've had the browser.sessionstore.restore_pinned_tabs_on_demand preference enabled so that my pinned tabs are not automatically restored when I restart Firefox (they restore when I select them, instead) for a while now.

It seems to have stopped working in the last few days. Didn't really pay attention the first few times it restored everything. I'll try to get a better regression range in a bit.

As far as I can see from http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/SessionStore.jsm#3483 this should all still be working, right?

Comment 1

[:Gijs (he/him)]

Tim and/or Steven, do you know about this?

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to :Gijs Kruitbosch from comment #1)
> Tim and/or Steven, do you know about this?

I can't think of any changes I was involved in that would have caused this. Maybe Yoric or Bill know?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I don't know of any recent changes here. However, the branch for this looks reversed.
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/SessionStore.jsm#3555
Maybe I'm misreading the code though. That change was checked in last May.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

I can't think of anything related to that, but I'll try looking at blamelogs next week.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Wes, can you find a regression range using mozregression?

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

I can't reproduce this and am tempted to close it. Wes, is this still reproducible using Firefox 29 and a fresh profile (maybe with your old session in it)?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, this seems to have either fixed itself, or was fallout from some extension that I'm no longer using. Or something.