985132 - [B2G][Homescreen]Input overlap with confirmation prompt when deleting apps from the dock

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: DeleteDockItemsLog.txt

A confirmation prompt appears whenever the user chooses to delete an app. When deleting an app that is stored in the dock, the touch input will overlap the confirm/deny buttons, meaning that apps on the right half of the screen get immediately deleted without a visible prompt, and apps on the left half of the screen will never be deleted because the cancel button is automatically pressed.

Repro Steps:
1) Updated Buri to BuildID: 20140318004002
2) Place some marketplace apps or smart collections in the dock at the bottom edge of the screen. 
3) Long press an app to summon the delete app menu. (delete-able apps display a small red x to indicate they can be deleted)
4) Tap the red x's on the apps that are located in the dock.

Actual:
Touching the red x also automatically touches the confirmation buttons. The app is either automatically deleted, or the deletion is automatically cancelled.

Expected:
The confirmation prompt doesn't appear until the user has lifted their finger off the screen.

Notes:
This issue occurs in both 1.4 and 1.3

Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140318000203
Gaia: c03a6af9028c4b74a84b5a98085bbb0c07261175
Gecko: 3776f72f1967
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140318004002
Gaia: 2ea2aab306bd1c941719160cdcb49ee9d755dc17
Gecko: cf2042938526
Version: 28.0
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
See attached: logcat, video

Comment 1

[Ross Kuhlman ([e-mail])]

Attachment: DockDeleting.mp4

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: 17320.html

Comment 4

[Preeti Raghunath(:Preeti)]

Cristian

We have 1.3+ this bug and would like the fix to be in 1.3. 

Please check if code base is different and do the needful

Comment 5

[Cristian Rodriguez (:crdlc)]

I would like to land it on master and after that cherry picking because I think that the code is very similar

(In reply to Preeti Raghunath(:Preeti) from comment #4)
> Cristian
> 
> We have 1.3+ this bug and would like the fix to be in 1.3. 
> 
> Please check if code base is different and do the needful

Comment 6

[Jason Smith [:jsmith]]

Leaving qawanted to check behavior on 1.1.

Comment 7

[Josh Schmitt [Joshs]]

(In reply to Jason Smith [:jsmith] from comment #2)
> Does this reproduce on 1.1?

Issue does not repro on 1.1

Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140318041202
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 2c70ef07c5b3
Version: 18.0
Firmware Version: V1.2-device.cfg

Comment 8

[Candice Serran (:cserran)]

Hi Vivien,

I think this bug has been waiting for review for 3 days now.  Do you have an ETA when we might get it reviewed?

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/81a9195ce5783ddb1a06b26cacb903ceaf6fb929

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request approval-gaia-v1.3 on this patch if it's ready for uplift to v1.3.

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8393505 [details]
17320.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 

no idea, it is happening from 1.1

[User impact] if declined:

very high, apps in the dock can be removed from device without confirmation

[Testing completed]:

added unit tests and manually by myself. No idea why QA didn't verify here

[Risk to taking this patch] (and alternatives if risky):

it seems to be that maintaining the current bug is riskier than taking this patch with specific unit tests.

[String changes made]:

no literals added in the patch

Jason, please, could someone verify this bug?

Comment 13

[Jason Smith [:jsmith]]

Sure - I can get someone to verify this.

Comment 14

[Roland Kunkel [:RolandK]]

After several attempts (duped bug reported <100% reproduction) I am unable to reproduce the issue on the latest v1.5 Master Buri build.

3/30 Environmental Variables:
Device: Buri 1.5 MOZ RIL
BuildID: 20140330040201
Gaia: 4cf7ec04b82320a1ff1f825220204f454f951a87
Gecko: 0e19655e93df
Version: 31.0a1
Firmware Version: V1.2-device.cfg

-

1) Removing verifyme keyword, verified against master v1.5.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/0a8bef164924c6533d66f0ac5b46ef8e331b1769
v1.3: https://github.com/mozilla-b2g/gaia/commit/c5cd3a11e91339163b351d50769eaca0067da860