985157 - [B2G][Marketplace][Calculator] Numbers on buttons are off-center

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: v1.4Numbers.png

Description:
The numbers and characters are not centered on the buttons of the calculator as they have been previously, they are very low on the buttons.

Repro Steps:
1) Updated Buri to BuildID: 20140318000203
2) Tap marketplace
3) Search for and install the calculator app
4) Launch the calculator app
5) Observe the numbers very low on the buttons of the calculator

Actual:
Numbers on the calculator buttons are not centered.

Expected:
Numbers are centered as previously seen on v1.3.

Environmental Variables:
Device: Buri v1.4 MOZ ril
BuildID: 20140318000203
Gaia: c03a6af9028c4b74a84b5a98085bbb0c07261175
Gecko: 3776f72f1967
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Notes: Unsure if this is a design choice.

Repro frequency: 100%
See attached: Screenshot

Comment 1

[Rachel Pribble [:rpribble]]

This issue does not occur on the Buri v1.3 MOZ ril.

Environmental Variables:
Device: Buri 1.3 MOZ ril
BuildID: 20140318004002
Gaia: 2ea2aab306bd1c941719160cdcb49ee9d755dc17
Gecko: cf2042938526
Version: 28.0
Firmware Version: V1.2-device.cfg

Numbers and characters on the buttons are centered.

Comment 2

[Jason Smith [:jsmith]]

Minor regression.

Comment 3

[Jason Smith [:jsmith]]

Regression windows would not be a good idea in this case - it's a minor bug, which is too low of a priority to pursue a window against the cost of how long it takes to do a window (8 - 10 hours).

The app is here for the record - https://github.com/mozilla/Calculator.

Comment 4

[Jason Smith [:jsmith]]

Attachment: Mostly Reduced Test Case

This isn't 100% reduced, but it's close. You can see the difference by testing this on Desktop Firefox Beta vs. Desktop Firefox Nightly.

Comment 5

[Jason Smith [:jsmith]]

mats - is the test case in comment 4 reduced enough to go off of?

Comment 6

[Jason Smith [:jsmith]]

I've also got a regression range down to a day so far:

3/13 - Working
3/14 - Busted

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=46041cc216fd&tochange=f073b3d6db1f

Comment 7

[Timothy Nikkel (:tnikkel)]

Given
  input { line-height: 6rem; }
in the testcase, most likely bug 349259.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the fix here is to fix the style sheet in question (probably by just removing the line-height declaration) -- we're honoring a style that we previously weren't honoring (and which other browsers honor).

(If the resulting problems were on major Web sites, I'd consider reverting the change, but in this case it should just be in the calculator code.)

Comment 9

[Jason Smith [:jsmith]]

(In reply to Timothy Nikkel (:tn) from comment #7)
> Given
>   input { line-height: 6rem; }
> in the testcase, most likely bug 349259.

Confirmed - removing this line of code causes us to get the same behavior on Firefox Beta & Nightly.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Where should bugs in the calculator app go?

Comment 11

[Jason Smith [:jsmith]]

Opened a pull request here: https://github.com/mozilla/calculator/pull/68

Comment 12

[Jason Smith [:jsmith]]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC+8, but slow response this week) from comment #10)
> Where should bugs in the calculator app go?

Probably TE --> Preinstalled B2G Apps, given that this is a preinstalled app that isn't directly part of Gaia.

Comment 13

[Jason Smith [:jsmith]]

Attachment: Pointer to Github Pull Request - https://github.com/mozilla/calculator/pull/68

Comment 14

[(not reading bugmail) Nick Desaulniers [:\n]]

Thanks for the patch.  I'm getting caught up on a lot of work, but I'll test this patch out when I get a chance. Because this app is not in Gaia, just preloaded on a lot of devices, I will have to test this patch in 1.1.  It does not have the privilege of only having to support one version of Gaia like Gaia apps do. :P

Comment 15

[(not reading bugmail) Nick Desaulniers [:\n]]

Looks good, will push out an update to MP.