985173 - [B2G][Marketplace] In the app 'Recomienda' there are two broken images in the tile view

Status: RESOLVED WONTFIX

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

Description

[demerick]

Attachment: logcat.txt

Description:
If the user switches to tile view in Recomienda they will see two broken images. These do not replace images, but are added when switching to this view. Please see attached screenshots.

Repro Steps:
1) Update a Buri to BuildID: 20140318004002
2) Install the app Recomienda from the marketplace and launch it from the home screen
3) Tap 'Don't Share'
4) Tap the 4 squares icon in the top right corner
5) Tap the 4 horizontal bars icon in the top right corner (same button as step 4)
6) Tap the 4 squares icon again
7) Scroll down

Actual:
The user will see two broken image/hyperlinks

Expected:
The user should not see any broken images

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140318000203
Gaia: c03a6af9028c4b74a84b5a98085bbb0c07261175
Gecko: 3776f72f1967
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[demerick]

Attachment: recomienda_tileView.png

This issue also occurs on the Buri v 1.3.0 Mozilla RIL

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140318004002
Gaia: 2ea2aab306bd1c941719160cdcb49ee9d755dc17
Gecko: cf2042938526
Version: 28.0
Firmware Version: v1.2-device.cfg

Two broken images are seen in Tile view in the app Recomendia when the user switches between tile and detailed view.

Comment 2

[demerick]

This issue does not occur on the Buri v 1.1.0 Mozilla RIL

1.1 Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140306041201
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 1421a6b7fc51
Version: 18.0
Firmware Version: v1.2-device.cfg

No broken images are seen in Tile view in the Recomendia app.

Comment 3

[Jason Smith [:jsmith]]

Can we get a screenshot of the behavior seen on 1.1?

Comment 4

[Josh Schmitt [Joshs]]

Attachment: 1.1.png

Uploaded a 1.1 picture

Comment 5

[Jason Smith [:jsmith]]

Milan - Do you know someone who would know why we would get broken images on 1.3 for 2 of the images, but have all images render on 1.1? I'm wondering how this could be a bug on our side & why.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Any chance we can get the two images attached to the bug that cause trouble? Just to see if it's a codec bug we may have fixed that now rejects those images as invalid where before they sneaked through.

We should also check for a more recent regression, there were some 1.3 imagelib changes earlier this week :)

Comment 7

[Jason Smith [:jsmith]]

(In reply to Milan Sreckovic [:milan] from comment #6)
> Any chance we can get the two images attached to the bug that cause trouble?
> Just to see if it's a codec bug we may have fixed that now rejects those
> images as invalid where before they sneaked through.

From using a UA spoofer on Desktop Firefox with Firefox OS as the UA, I can't find the particular image in question. However, we might be able to get that information from remote debugging on device.

Comment 8

[Matthew Vaughan]

This issue looks to have started on the 10/08/13 1.3 build at the latest. The 10/06 and 10/07 builds do not load past the Firefox splash screen on start up so they could not be tested.

- Last Working -
Device: Buri v1.3 MOZ RIL
BuildID: 20131005040201
Gaia: c9090021f7d642bae1db73a1093ab3dbb5078642
Gecko: b5d24ef1eb37
Version: 27.0a1
Firmware Version: V1.2-device.cfg

- First Broken -
Device: Buri v1.3 MOZ RIL
BuildID: 20131008064334
Gaia: 122ff8c6363227501f4121e5a3892ba41d4c0417
Gecko: 64b497e6f593
Version: 27.0a1
Firmware Version: V1.2-device.cfg


**This looks to be a gecko issue**
last working gaia/first broken gecko = REPRO
Gaia: c9090021f7d642bae1db73a1093ab3dbb5078642
Gecko: 64b497e6f593

first broken gaia/last working gecko = NO REPRO
Gaia: 122ff8c6363227501f4121e5a3892ba41d4c0417
Gecko: b5d24ef1eb37

Push log: http://hg.mozilla.org//mozilla-central/pushloghtml?fromchange=b5d24ef1eb37&tochange=64b497e6f593

Comment 9

[Jason Smith [:jsmith]]

Attachment: Broken Image - HTML Code Screenshot

Comment 10

[Jason Smith [:jsmith]]

Attachment: Working Image - HTML Code Screenshot

Comment 11

[Jason Smith [:jsmith]]

Here's a direct link to the images not working:

* http://www.movistarrecomienda.es/upload/92c8c28233/URL_THUMBAIL_20130916.png
* http://www.movistarrecomienda.es/upload/e37968bcb7/URL_THUMBAIL_20130916.png

Comment 12

[Jason Smith [:jsmith]]

bug 922931 is a potential suspect for causing this bug

Comment 13

[Jason Smith [:jsmith]]

Going to investigate the points Johnny suggested - which was:

1. See if this reproduces on Desktop with a FxOS UA spoof
2. Disable browser cache, browser memory, and network http usecache and try to reproduce

While I'm digging into this, I'd like to get input on whether bug 922931 could have caused this.

Boris - What do you think?

Comment 14

[Boris Zbarsky [:bzbarsky]]

Before bug 922931, in standards mode a broken <img> with no alt attribute was completely invisible.

After that bug, it shows a broken-image icon.

So presumably these images were broken all along but were simply not being shown, and now they're being shown.

The possible fixes are to add alt="" to the images if they're _meant_ to be broken but shouldn't be visible, or to fix them to not be broken.

Comment 15

[Masatoshi Kimura [:emk]]

But according to attachment #8394449 [details], the broken image has an alt attribute.
<img alt="" src="http://www.movistarrecomienda.es/upload/92c8c28233/URL_THUMBAIL_20130916.png"></img>
Moreover, this image is not broken when opening it directly.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Yes, I'm having a hard time with the various contradictory bits in this bug...

Comment 17

[Preeti Raghunath(:Preeti)]

(In reply to Jason Smith [:jsmith] from comment #13)
> Going to investigate the points Johnny suggested - which was:
> 
> 1. See if this reproduces on Desktop with a FxOS UA spoof
> 2. Disable browser cache, browser memory, and network http usecache and try
> to reproduce
> 
> While I'm digging into this, I'd like to get input on whether bug 922931
> could have caused this.
> 
> Boris - What do you think?

Adding QA wanted for further investigation on QA.

Comment 18

[Preeti Raghunath(:Preeti)]

Please update bug with your investigation

Comment 19

[Jason Smith [:jsmith]]

Attachment: Img Tag Only Test Case

Comment 20

[Jason Smith [:jsmith]]

Confirmed this does reproduce on Desktop Firefox Nightly with the user agent spoofed to FxOS.

Comment 21

[Jason Smith [:jsmith]]

Figured it out. This line appears to be causing the trouble:

<img src="" class="img_grid" ruta="">

In Firefox 26 or earlier, we displayed this as invisible, so Kayak & Facebook never showed up. In Firefox 27 or later due to the spec change in gecko, we show a broken icon here.

On that regard, this is a TE bug with the app. The difference in behavior is just due to a spec change in gecko, but the bug exists across both versions (i.e. not a regression).

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.

Comment 23

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.