985174 - Remove unused FHR Gecko prefs for datanotification

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

In DataReportingNotification, the code that fires off Android notifications for alerting users of our data policy uses SharedPrefs because it might called while Gecko isn't running. However, we don't use the convention for naming non-Gecko-prefs, which is confusing because on top of that, we also use the same names as the (unused) Gecko prefs.

A comment to that effect, explaining why we don't use Gecko prefs would also be nice.

However, I'm not sure if this is worth the trouble of a SharedPref migration, since I assume that we'll just have to have to keep that version check around in the code forever...

Comment 1

[Richard Newman [:rnewman]]

Can you summarize why this is a bad thing?

We store a lot of stuff in SharedPreferences that doesn't map to a Gecko pref. And this pref is per-app, not per-profile, so it naturally doesn't map to a Gecko pref value.

As I understand it, the only purpose of not_a_pref is for stuff that's in preferences.xml but isn't automatically replicated.

Comment 2

[Chenxia Liu [:liuche]]

This is not a terrible thing, but it's messy naming convention because there are unused Fennec datareporting Gecko prefs that are named the exact same thing as the datareporting SharedPreferences. The android_not_a_pref *is* used for filtering out SP prefs that shouldn't be mirrored in Gecko, but that doesn't mean we couldn't use it to be explicit that these are only Android prefs.

But maybe all this just means that we should remove those datareporting Gecko prefs from Fennec!

Comment 3

[Richard Newman [:rnewman]]

(In reply to Chenxia Liu [:liuche] from comment #2)

> But maybe all this just means that we should remove those datareporting
> Gecko prefs from Fennec!

We should! If they're not used, they're just misleading. We already write through to the telem pref, so if there are prefs in Gecko for FHR, we should kill them.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.