985184 - WebappsUpdateTimer.js not packaged with Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: obvious, trivial fix

The WebappsUpdateTimer.js component script isn't included in Fennec's package manifest, so it isn't being packaged with Fennec, and the update timer manager isn't able to trigger a periodic automatic update check.

The fix is obvious and trivial.  (And it begs the question why I didn't catch this in testing, where I'm sure I saw these timers fire, although now I don't see how I could have.)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3f8ffe30e2b

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8393190 [details] [diff] [review]
patch v1: obvious, trivial fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 934760.

User impact if declined: 
  Fennec will not check for webapp updates automatically.

Testing completed (on m-c, etc.): 
  I tested this locally and have pushed it to inbound.

Risk to taking this patch (and alternatives if risky): 
  The risk is low, as it's a small, obvious patch.

String or IDL/UUID changes made by this patch:
  None

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3f8ffe30e2b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c801b0f77519
https://hg.mozilla.org/releases/mozilla-beta/rev/e882a4512404