985195 - WebappsUpdateTimer shares timer ID with nsUpdateService

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: obvious fix

The component manifest entry for WebappsUpdateTimer declares its ID to be "background-update-timer", which is the same ID as for nsUpdateService.  My reading of nsUpdateTimerManager.js suggests that this will cause one of them to replace the other in the manager's hash of timers, probably preventing the replaced one from being notified when the timer expires (and possibly causing other issues).

Here's the obvious fix: give WebappsUpdateTimer a unique ID.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8393208 [details] [diff] [review]
patch v1: obvious fix

>+category update-timer WebappsUpdateTimer @mozilla.org/b2g/webapps-update-timer;1,getService,webapp-background-update-timer,browser.webapps.updateInterval,86400

I suppose the "b2g" part of the component ID is not a big deal

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> I suppose the "b2g" part of the component ID is not a big deal

I don't think so, but see bug 985295 for details on why and a patch that changes it anyway.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bdfaed5b5ac4

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8393208 [details] [diff] [review]
patch v1: obvious fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 934760.

User impact if declined: 
  It's unclear, since this bug does not seem to have affected the update
  service's ability to check for updates on Nightly/Aurora.  But in theory
  it could interfere with that ability.  That presumably wouldn't matter on
  Beta, which we distribute via Google Play.  But it would matter on Aurora,
  and it feels safer to take the patch for Beta too.

Testing completed (on m-c, etc.): 
  I tested this locally and have pushed it to inbound.

Risk to taking this patch (and alternatives if risky): 
  The risk is low, as it's a small, obvious patch.

String or IDL/UUID changes made by this patch:
  None.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bdfaed5b5ac4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/49ba78ba7606
https://hg.mozilla.org/releases/mozilla-beta/rev/cc3aecaf0f5b