Closed Bug 985217 Opened 6 years ago Closed 6 years ago

[Skia] Update Skia, 2014-03-18 (Firefox 31)

Categories

(Core :: Graphics, enhancement)

x86_64
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: gw280, Assigned: gw280)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

This is the first planned landing of the new Skia update schedule - once per train. This is targeting Firefox 31.
Enable legacy APIs for now, file bugs immediately after landing to track making the appropriate changes to gfx/2d to no longer require these.
Attachment #8394309 - Flags: review?(snorp)
I missed upstreaming this the last time round. Will upstream asap.
Attachment #8394312 - Flags: review?(snorp)
Attachment #8394309 - Flags: review?(snorp) → review+
Attachment #8394310 - Flags: review?(snorp) → review+
Attachment #8394311 - Flags: review?(snorp) → review+
Attachment #8394312 - Flags: review?(snorp) → review+
Comment on attachment 8394313 [details] [diff] [review]
0006-Bug-985217-Ensure-that-our-GLContext-is-current-and-.patch

Review of attachment 8394313 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SkiaGLGlue.cpp
@@ +39,5 @@
> +}
> +
> +void EnsureGLContext(const GrGLInterface* i)
> +{
> +    const SkiaGLGlue* contextSkia = reinterpret_cast<const SkiaGLGlue*>(i->fCallbackData);

Maybe add a null guard here, since maybe Skia will someday start calling this at creation time too.
Attachment #8394313 - Flags: review?(snorp) → review+
Depends on: 1106808
You need to log in before you can comment on or make changes to this bug.