985257 - Add Path2D constructor that takes a SVG path string

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Comment 1

[Rik Cabanier]

spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-path-withdata

Also implemented in Blink and WebKit

Comment 2

[Rik Cabanier]

Attachment: Bug 985257 - add implementation for Path2D constructor that takes an SVG path string

Comment 3

[Rik Cabanier]

Attachment: Bug 985257 - add implementation for Path2D constructor that takes an SVG path string

Comment 4

[Rik Cabanier]

Comment on attachment 8393287 [details] [diff] [review]
Bug 985257 - add implementation for Path2D constructor that takes an SVG path string

no tests yet.
Waiting for pointInPath patch to land first

Comment 5

[Robert Longson [:longsonr]]

The code you've put in nsSVGUtils would be better located in SVGContentUtils. Could you move it there please?

Comment 6

[Rik Cabanier]

(In reply to Robert Longson from comment #5)
> The code you've put in nsSVGUtils would be better located in
> SVGContentUtils. Could you move it there please?

SVGContentUtils.h is not reachable from CanvasRenderingContext2D.cpp
It seems like it's only meant to be used inside the SVG tree.

Comment 7

[Robert Longson [:longsonr]]

You should change the moz.build file(s) to make it reachable if you need to.

Comment 8

[Rik Cabanier]

Attachment: Bug 985257 - add implementation + test for Path2D constructor that takes an SVG path string

Comment 9

[Rik Cabanier]

try build: https://tbpl.mozilla.org/?tree=Try&rev=a2ccc8c9e639

Comment 10

[Rik Cabanier]

(In reply to Robert Longson from comment #7)
> You should change the moz.build file(s) to make it reachable if you need to.

Can you review?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c807b1e3d4

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage (which you probably would have seen had you not pushed to Try on top of other bustage).
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cf18ff619d

https://tbpl.mozilla.org/php/getParsedLog.php?id=36500526&tree=Mozilla-Inbound

Comment 13

[Rik Cabanier]

Attachment: add implementation + test for Path2D constructor that takes an SVG path string

Comment 14

[Rik Cabanier]

new try build: https://tbpl.mozilla.org/?tree=Try&rev=eb4f961a13ef

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee23d53dc27

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ee23d53dc27

Comment 17

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/API/Path2D.Path2D