985273 - [DSDS] SIM labels of missed calls & sms in Notification is different

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: Notification.png

GAIA_REV=2346ad9002062d70b6b27978c6b942f04192bf1b
GECKO_REV=93246f13841850c267bbb15915bffa7c2fcdac46
GAIA_BRANCH=mozillaorg/master
GECKO_BRANCH=mozillaorg/master
BUILD_TAG=jenkins-B2G.master.fugu-33
BuildID=20140319053035

1. Make missed calls and send SMS to Fugu.
2. Space missing in label.
3. Check Notification.png, (SIM 1) shown for missed call. (SIM1) for SMS.

Comment 1

[Julien Wajsberg [:julienw]]

Hey Carrie, can you please comment whether we should have (SIM 1) or (SIM1) in the notification?

I think the spec says that we have "SIM1" on buttons but "SIM 1" in notifications, that's why I'd like that you comment here :)

Thanks!

Comment 2

[Julien Wajsberg [:julienw]]

Gregor, Joe, it's really a Comms App issue (either Dialer or SMS). Do you think we should retriage this on our side?

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Julien Wajsberg [:julienw] (away until March 24) from comment #2)
> Gregor, Joe, it's really a Comms App issue (either Dialer or SMS). Do you
> think we should retriage this on our side?

Fine with me. I took it because fixing this typo is probably faster than discussing who should fix it :)

Comment 4

[Julien Wajsberg [:julienw]]

Gregor> yep, I just wait for Carrie to say where the typo is... ;)

Comment 5

[Carrie Wang [New account: [e-mail]]]

Hey Julien, it should always show "SIM 1" (with a space inserted).
Thanks!

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

with the correct comms team component, this will show up in comms team triage. will mark the bug appropriately in triage meeting

Comment 7

[Preeti Raghunath(:Preeti)]

Moving to backlog

Comment 8

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hi Julien,

I've just changed label in this patch. 

Probably we'll also need to deal later with the case when this label isn't translated right after language switch (in notification and report panel).

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8451454 [details] [review]
GitHub pull request URL

r=me if you keep it like this but please request another review if you decide to change dialog.js

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8451454 [details] [review]
GitHub pull request URL

(In reply to Julien Wajsberg [:julienw] from comment #9)
> Comment on attachment 8451454 [details] [review]
> GitHub pull request URL
> 
> r=me if you keep it like this but please request another review if you
> decide to change dialog.js

Thanks for review! I've updated dialog.js (in a separate commit), so asking for review once again :)

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8451454 [details] [review]
GitHub pull request URL

r=me
please squash+rebase+wait for travis or gaia try, the usual drill :)

Comment 12

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #11)
> Comment on attachment 8451454 [details] [review]
> GitHub pull request URL
> 
> r=me
> please squash+rebase+wait for travis or gaia try, the usual drill :)

Thanks!

Master: https://github.com/mozilla-b2g/gaia/commit/dde24450450514039bad6d8ab4fcb7e5d4d44e03

Comment 13

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.1.png

Verified fixed in v2.1, with flame
Gaia      d29773d2a011825fd77d1c0915a96eb0911417b6
Gecko     https://hg.mozilla.org/mozilla-central/rev/4024d8019701
BuildID   20140716160202
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220