Closed Bug 985313 Opened 11 years ago Closed 11 years ago

Set error_reporting level to E_ERROR in prefetch.php

Categories

(www.mozilla.org :: Legacy PHP system, defect)

Production
x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jgmize, Unassigned)

Details

(Whiteboard: [kb=1307948] r=125537)

Attachments

(1 file)

We get a large number of errors at the E_WARNING level that trigger multiple alerts a day from New Relic about the the php side of mozilla.org exceeding 5% error rate. The vast majority of these errors are one particular issue that is not worth fixing due to the effort and risk involved in making any significant modifications to prefix.php, which is currently used on every single request, even the ones that ultimately get served by bedrock. By simply adding the line "error_reporting(E_ERROR);" near the top of the file, our New Relic alerts on the PHP side should become useful again instead of being filled with noise.
Attached patch bug-985313.patchSplinter Review
Attachment #8393639 - Flags: review?(jmize)
Assignee: nobody → mozbugs.retornam
Whiteboard: [kb=1307948]
I'm not sure what `config.inc.php` says on the server, but the distributed one sets this to `E_ALL`. So perhaps we should just file an IT bug to change these values? http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/config.inc.php-dist?view=markup#l194
Flags: needinfo?(jmize)
Committed to trunk in r125537.
Whiteboard: [kb=1307948] → [kb=1307948] r=125537
Committed to stage in r125538.
Committed to prod in r125539.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(jmize)
Attachment #8393639 - Flags: review?(jmize) → review+
Assignee: mozbugs.retornam → nobody
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: