985313 - Set error_reporting level to E_ERROR in prefetch.php

Status: VERIFIED FIXED

(www.mozilla.org :: Legacy PHP system, defect)

Description

[Josh Mize [:jgmize]]

We get a large number of errors at the E_WARNING level that trigger multiple alerts a day from New Relic about the the php side of mozilla.org exceeding 5% error rate. The vast majority of these errors are one particular issue that is not worth fixing due to the effort and risk involved in making any significant modifications to prefix.php, which is currently used on every single request, even the ones that ultimately get served by bedrock. By simply adding the line "error_reporting(E_ERROR);" near the top of the file, our New Relic alerts on the PHP side should become useful again instead of being filled with noise.

Comment 1

[raymond [:retornam] (inactive)]

Attachment: bug-985313.patch

Comment 2

[Paul [:pmac] McLanahan]

I'm not sure what `config.inc.php` says on the server, but the distributed one sets this to `E_ALL`. So perhaps we should just file an IT bug to change these values?

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/config.inc.php-dist?view=markup#l194

Comment 3

[Paul [:pmac] McLanahan]

Committed to trunk in r125537.

Comment 4

[Paul [:pmac] McLanahan]

Committed to stage in r125538.

Comment 5

[Paul [:pmac] McLanahan]

Committed to prod in r125539.