985318 - Convert to Promise.jsm in the Toolkit "content" folder

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[:Paolo Amadini]

Attachment: The patch

This conversion required some changes in the front-end tests as well, since contentAreaUtils.js is included there.

A limited tryserver run is green with the test changes:

https://tbpl.mozilla.org/?tree=Try&rev=dbf37dc5d515

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8393353 [details] [diff] [review]
The patch

Review of attachment 8393353 [details] [diff] [review]:
-----------------------------------------------------------------

ugh, so the searchbar is reusing the Promise module imported from contentAreaUtils? ugh, that sucks from a modularity of code point of view, we should fix bug 619418 soon or later (if not that it will probably break add-ons :( )

::: browser/components/customizableui/test/browser_901207_searchbar_in_panel.js
@@ +84,5 @@
>  
>    let chevron = document.getElementById("nav-bar-overflow-button");
>    yield waitForCondition(function() chevron.open);
> +
> +  yield waitForSearchBarFocus();

"let searchbar" is no more useful for this test (you removed the only usage)

Comment 2

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/a1945d5e465f

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1945d5e465f