Closed
Bug 985318
Opened 10 years ago
Closed 10 years ago
Convert to Promise.jsm in the Toolkit "content" folder
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
7.37 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
This conversion required some changes in the front-end tests as well, since contentAreaUtils.js is included there. A limited tryserver run is green with the test changes: https://tbpl.mozilla.org/?tree=Try&rev=dbf37dc5d515
Attachment #8393353 -
Flags: review?(mak77)
Comment 1•10 years ago
|
||
Comment on attachment 8393353 [details] [diff] [review] The patch Review of attachment 8393353 [details] [diff] [review]: ----------------------------------------------------------------- ugh, so the searchbar is reusing the Promise module imported from contentAreaUtils? ugh, that sucks from a modularity of code point of view, we should fix bug 619418 soon or later (if not that it will probably break add-ons :( ) ::: browser/components/customizableui/test/browser_901207_searchbar_in_panel.js @@ +84,5 @@ > > let chevron = document.getElementById("nav-bar-overflow-button"); > yield waitForCondition(function() chevron.open); > + > + yield waitForSearchBarFocus(); "let searchbar" is no more useful for this test (you removed the only usage)
Attachment #8393353 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a1945d5e465f
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1945d5e465f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•