985333 - [Keyboard UX update][User Story] Default Upper case layout and typing hints

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Bruce Huang [:bhuang] (inactive)]

As a user, I want the hints that appear while I type to reflect the current case so I know what to expect when the input appears.

Acceptance:
Layout letters are in caps by default
Letter hints when typing reflect the current case (upper/lower case).

Refer to p.7 of UX spec in bug 983043

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Isn't this a dup of bug 947558 ?  I guess this is a user story ?

Comment 2

[Omega Feng [:Omega] [:馮於懋]]

See bug 983043 for the UX spec update.

Comment 3

[William Hsu [:whsu]]

Add the test cases
- https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2629

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1)
> Isn't this a dup of bug 947558 ?  I guess this is a user story ?

Yes, this bug was opened as a user story.
Going to dupe that bug to this one.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pr 18569

I have a WIP here, but seems it would cause reflow.
Going to find an alternative way to show the case-sensitive pop-up.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8411636 [details] [review]
Patch V1 - pr 18569

Patch updated to put extra elements inside .visual-wrapper for uppercase/lowercase key popups.
These extra elements are added to avoid reflows if we changes "content: attr()" rule with different selectors.

Jan,

Could you please help review this?
Thank you.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8411636 [details] [review]
Patch V1 - pr 18569

Also ask for Tim's help to review this since Jan is not available recently.

Tim,

Could you help?
Thanks.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8411636 [details] [review]
Patch V1 - pr 18569

And need Omega to do ui review for this new feature.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8411636 [details] [review]
Patch V1 - pr 18569

I didn't read the CSS or verify the visual, please reflag review if I need to.

Also, do we have tests for IMERender?

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Unit test added for IMERender.

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/c3f7b6a1692cc7d94d35002cc1d5aa236653e6d7

--
Thanks for the review.