985403 - Gaia ui tests not setting symbols path and minidump stackwalk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Andrew Halberstadt [:ahal]]

In https://tbpl.mozilla.org/php/getParsedLog.php?id=36359908&tree=Mozilla-Inbound

I noticed:
16:22:23     INFO -  No symbols path given, can't process dump.
16:22:23     INFO -  MINIDUMP_STACKWALK not set, can't process dump.

I thought this was working already, but apparently not?

Comment 1

[Andrew Halberstadt [:ahal]]

So symbols_path is passed into the constructor when we have an emulator, but otherwise not:
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/base.py#633

I don't like that the Marionette constructor is called in four different places. I think it makes it easy to not pass in arguments into all the places we should be (like symbols_path). I think I'm going to refactor this a bit so we build the arguments first and then only have one Marionette constructor call.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Refactor BaseMarionetteRunner.start_marionette and pass in symbols_path by default

I'm almost certain this patch is equivalent to the old way, but here's a try run just in case:
https://tbpl.mozilla.org/?tree=Try&rev=93b94958e013

Imo, this is easier to read, plus it's easy to see where a new option needs to get added depending on what scenario it's supposed to be used in.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: (mozharness) install minidump stackwalk in b2g desktop Gu

Comment 4

[Andrew Halberstadt [:ahal]]

One thing I forgot to mention about attachment 8393492 [details] [diff] [review], I removed the getMarionetteOrExit entry from the emulator code path. That was a hack we introduced back when we were installing gecko into the emulator which we don't really need anymore. We should probably remove it in all the other harnesses too, but that is out of scope for this bug.

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Refactor start_marionette and add symbols_path everywhere

Oops, made a minor typo.

New try runs:
https://tbpl.mozilla.org/?tree=Try&rev=06b98ef8b6be
https://tbpl.mozilla.org/?tree=Try&rev=eaf619dd28f7

(Did two because apparently specifying both marionette and marionette-webapi doesn't work?)

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8393506 [details] [diff] [review]
(mozharness) install minidump stackwalk in b2g desktop Gu

Review of attachment 8393506 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that looks right. :)

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8393660 [details] [diff] [review]
Refactor start_marionette and add symbols_path everywhere

Review of attachment 8393660 [details] [diff] [review]:
-----------------------------------------------------------------

Try looks good.

Comment 9

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/build/mozharness/rev/9c65c8f4cb47

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8393660 [details] [diff] [review]
Refactor start_marionette and add symbols_path everywhere

Review of attachment 8393660 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this is much more concise.

Comment 11

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8a7dfed4ace

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8a7dfed4ace