Closed
Bug 985409
Opened 11 years ago
Closed 11 years ago
Fix JSHint issues with test/unit/setup.js
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Firefox OS Graveyard
Gaia::Settings
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rik, Assigned: rik)
References
Details
Attachments
(1 file)
Bug 964180 added setup.js to the xfail.list. We shouldn't be adding entries to this file because we want all the code base to be checked with JSHint. Evelyn, Arthur, please pay attention to this during reviews.
I have a patch for this.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8393445 -
Flags: review?(arthur.chen)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8393445 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/17323
Thanks for point that out. Somehow I couldn't get it work by passing the window object. r=me.
Attachment #8393445 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•11 years ago
|
||
I had to revert the commit when reverting bug 964180. Will fix the issue when re-landing.
master: 61c408c49aa8f3da0f5bec4c9bc6a5f62aa4db39
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•11 years ago
|
||
bug 964180 seems to have landed again. Can we land this too?
Flags: needinfo?(arthur.chen)
|
|
||
Comment 6•11 years ago
|
||
I fixed the issue when re-landing. I should close the bug.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(arthur.chen)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•