Closed
Bug 985423
Opened 11 years ago
Closed 11 years ago
browser_scratchpad_reload_and_run.js | A promise chain failed to handle a rejection | TypeError: this.editor is null
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: Yoric, Assigned: past)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
Details | Diff | Splinter Review |
Once we land bug 976205, the following errors will cause oranges.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/scratchpad/test/browser_scratchpad_reset_undo.js | A promise chain failed to handle a rejection at chrome://browser/content/devtools/scratchpad.js:497 - TypeError: this.editor is null
04:49:11 INFO - Stack trace:
04:49:11 INFO - SP_run/<@chrome://browser/content/devtools/scratchpad.js:497:9
04:49:11 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:809:11
04:49:11 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:7
For testing, you may wish to import the patch of bug 976205.
|
Reporter | |
Updated•11 years ago
|
|
|
Reporter | |
Updated•11 years ago
|
|
Assignee | |
Comment 1•11 years ago
|
||
I can no longer reproduce this with the patch from bug 1016387 applied. Tried both debug and opt builds with --run-until-failure.
Assignee: nobody → past
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
|
|
Assignee | |
Comment 2•11 years ago
|
||
Sigh. I can reproduce it again today, but it turns out that it's the previous test that causes the error, even though the harness reports it in browser_scratchpad_reset_undo.js. It is actually browser_scratchpad_reload_and_run.js that is the culprit. Will investigate further.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
|
|
Assignee | |
Updated•11 years ago
|
Summary: browser_scratchpad_reset_undo.js | A promise chain failed to handle a rejection | TypeError: this.editor is null → browser_scratchpad_reload_and_run.js | A promise chain failed to handle a rejection | TypeError: this.editor is null
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
The previous comment is a bug in the bzpost hg extension, teh patch hasn't landed yet.
|
|
Assignee | |
Comment 5•11 years ago
|
||
This fixes the error.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Now the patch landed, with the same cset ID.
|
||
Comment 7•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•