985425 - browser_webconsole_bug_601667_filter_buttons.js | A promise chain failed to handle a rejection - TypeError: this.webConsoleClient is null

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Once we land bug 976205, the following errors will cause oranges.

04:57:22  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601667_filter_buttons.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:411 - TypeError: this.webConsoleClient is null
04:57:22     INFO -  Stack trace:
04:57:22     INFO -      WCF_setSaveRequestAndResponseBodies@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:411:5
04:57:22     INFO -  WCF__initUI/reverseSaveBodiesPref/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:533:46
04:57:22     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:809:11
04:57:22     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:7

For testing, you may wish to import the patch of bug 976205.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: bug985425-1.diff

Changes:

- the filter buttons test was clicking the 'log network request and response bodies' menu item for no reason. On test end the function responsible for that menuitem command was throwing, due to early disconnect.

- changed the menuitem command handler to not fail in other similar situations.

- the highlighter_console_helper test was failing locally, depending on window size. h1.scrollIntoView() fixed the problem.

Thanks!

Comment 2

[Brandon Benvie [:benvie]]

Comment on attachment 8397378 [details] [diff] [review]
bug985425-1.diff

Review of attachment 8397378 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Ship it!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/da1daabfee72

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da1daabfee72