985463 - onclick opens 2 times the same link

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[kanenas]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

1. Please go to http://www.vistabet.gr/t/games/gamesroom.aspx
2. Press on the big banner(the rotating banner) the 3rd,4th and or 5th
images 
3. the link opens on the popup window and on the main page.



Actual results:

The onclick link open on the popup windows and on the main window.
If I use any other browser including e.g. firefox 27 this does not happened.


Expected results:

the link should open only on the popup window

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/06b3a7aea2c0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131208154802
Bad:
http://hg.mozilla.org/mozilla-central/rev/551efcc4de6f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131208185601
Puahlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=06b3a7aea2c0&tochange=551efcc4de6f


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/046cf0c4f858
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131207204100
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2aaff66026ba
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131208075200
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=046cf0c4f858&tochange=2aaff66026ba

Regressed by:
Bug 930374 - Event.defaultPrevented shouldn't become true if preventDefault() was called by our internal handler for default action

Comment 2

[Alice0775 White]

Attachment: reduced html

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Cannot reproduce on 29 or later? Then, this should be marked as WONTFIX if broken sites are not so many.

Comment 4

[Alice0775 White]

I can also reproduce the promlem on Aurora30 and Nightly31.

I am not sure, but this may happen with the combination of GTM (google tag manager) and onclick of <a> tag.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Alice0775 White from comment #4)
> I can also reproduce the promlem on Aurora30 and Nightly31.
> 
> I am not sure, but this may happen with the combination of GTM (google tag
> manager) and onclick of <a> tag.

Then, why did you mark them as unaffected?

Comment 6

[Alice0775 White]

Sorry my bad.
I changed status.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Naveed, it is possible to have someone working on that? Thanks

Comment 8

[Alice0775 White]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Naveed, it is possible to have someone working on that? Thanks

This was fixed by Bug 985988

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Cool, thanks Alice!

Comment 10

[Catalin Varga [QA][:VarCat]]

I can't reproduce this bug using the regression window provided by Alice.
Maybe the provided site http://www.vistabet.gr/t/games/gamesroom.aspx has suffered changes but for me the link are opened in pop-up pages or on the main page, never on both.
Alice can you help verify this bug, since you managed to reproduced it ?

Comment 11

[kanenas]

Hi 
We fixed it by using this command (in other words delete href and add the link on the onclick 
<a onclick="SB.base.OpenDiv('some-url','popBadSelect2','popVeil2','popLayer2'); return false;"></a>

but you can still reproduce it, using e.g.
<a href="some-url" onclick="SB.base.OpenDiv(this.href,'popBadSelect2','popVeil2','popLayer2'); return false;"></a>

Regards
Kanenas

Comment 12

[Catalin Varga [QA][:VarCat]]

Thanks for the prompt answer.
Also I'm removing the needinfo request as I managed to reproduce the issue.

Comment 13

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 29.0b6
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Build Id: 20140407135746
Os: Windows 7 x64.

Comment 14

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using an old Nightly (2014-03-19), verified as fixed on Firefox 30 beta 2 and latest Aurora.