985484 - [WebVTT] Remove TextTrackCue::CueChanged

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

This method is not needed in the current spec version. I'm unsure if it was ever needed. The purpose of it was to dispatch 'oncuechange' events, but reading the spec these events only happen in the 'time marches on' algorithm when a cue either becomes active or stops being active.

See: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#event-media-cuechange

And: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#time-marches-on step 16.

Also see bug 952130 for more info.

Comment 1

[Rick Eyre (:reyre)]

Attachment: v1: Remove TextTrackCue::CueChange r=cpearce

Comment 2

[Rick Eyre (:reyre)]

Attachment: v2: Remove TextTrackCue::CueChange r=cpearce

Just rebasing.

Carrying forward r=cpearce.

Comment 3

[Rick Eyre (:reyre)]

Thanks for review Chris.

Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=c3c1a4afff4c

Please land bug 977302 before this one.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28f1d36605dc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/28f1d36605dc