Closed Bug 985484 Opened 7 years ago Closed 7 years ago

[WebVTT] Remove TextTrackCue::CueChanged

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: reyre, Assigned: reyre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This method is not needed in the current spec version. I'm unsure if it was ever needed. The purpose of it was to dispatch 'oncuechange' events, but reading the spec these events only happen in the 'time marches on' algorithm when a cue either becomes active or stops being active.

See: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#event-media-cuechange

And: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#time-marches-on step 16.

Also see bug 952130 for more info.
Attachment #8393520 - Flags: review?(cpearce)
Attachment #8393520 - Flags: review?(cpearce) → review+
Just rebasing.

Carrying forward r=cpearce.
Attachment #8393520 - Attachment is obsolete: true
Thanks for review Chris.

Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=c3c1a4afff4c

Please land bug 977302 before this one.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/28f1d36605dc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.