985487 - <core_glBindTexture:484>: GL_INVALID_ENUM

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Seeing this both on Nexus S on 4.0 and Nexus 4 on 4.3.

W/Adreno200-ES20( 7198): <core_glBindTexture:484>: GL_INVALID_ENUM
W/TextureGenerator( 7198): Clearing GL error: 0x500

Happens during normal browsing, but for example trying a WebRTC call causes this to endlessly spew on the console.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like it's some cleanup code in the compositor:

#0  0x76a2a3f6 in mozalloc_abort (msg=<optimized out>) at /Users/snorp/source/gecko-dev/memory/mozalloc/mozalloc_abort.cpp:30
#1  0x7e0f1936 in Abort (aMsg=0x881fd5b4 "[22571] ###!!! ABORT: file /Users/snorp/source/gecko-dev/gfx/gl/GLContext.h, line 651")
    at /Users/snorp/source/gecko-dev/xpcom/base/nsDebugImpl.cpp:421
#2  NS_DebugBreak (aSeverity=<optimized out>, aStr=0x0, aExpr=0x0, aFile=0x7fc9442a "/Users/snorp/source/gecko-dev/gfx/gl/GLContext.h", aLine=651)
    at /Users/snorp/source/gecko-dev/xpcom/base/nsDebugImpl.cpp:408
#3  0x7e5f4b8a in AfterGLCall (this=<optimized out>, glFunction=<optimized out>) at /Users/snorp/source/gecko-dev/gfx/gl/GLContext.h:651
#4  mozilla::gl::GLContext::AfterGLCall (this=<optimized out>, 
    glFunction=0x7ffaac38 <mozilla::gl::GLContext::fBindTexture(unsigned int, unsigned int)::__PRETTY_FUNCTION__> "void mozilla::gl::GLContext::fBindTexture(GLenum, GLuint)")
    at /Users/snorp/source/gecko-dev/gfx/gl/GLContext.h:635
#5  0x7e67a676 in mozilla::layers::CompositorOGL::EndFrame (this=0x88675580) at /Users/snorp/source/gecko-dev/gfx/layers/opengl/CompositorOGL.cpp:1194
#6  0x7e66e5f6 in mozilla::layers::LayerManagerComposite::Render (this=0x88b91eb0) at /Users/snorp/source/gecko-dev/gfx/layers/composite/LayerManagerComposite.cpp:511
#7  0x7e66e782 in EndTransaction (aFlags=<optimized out>, this=0x88b91eb0, aCallback=<optimized out>, aCallbackData=<optimized out>)
    at /Users/snorp/source/gecko-dev/gfx/layers/composite/LayerManagerComposite.cpp:245
#8  mozilla::layers::LayerManagerComposite::EndTransaction (this=0x88b91eb0, aCallback=<optimized out>, aCallbackData=<optimized out>, aFlags=<optimized out>)
    at /Users/snorp/source/gecko-dev/gfx/layers/composite/LayerManagerComposite.cpp:202
#9  0x7e660264 in mozilla::layers::LayerManagerComposite::EndEmptyTransaction (this=0x88b91eb0, aFlags=<optimized out>)
    at /Users/snorp/source/gecko-dev/gfx/layers/composite/LayerManagerComposite.cpp:197
#10 0x7e6668ee in mozilla::layers::CompositorParent::CompositeToTarget (this=0x88d2ac00, aTarget=<optimized out>)
    at /Users/snorp/source/gecko-dev/gfx/layers/ipc/CompositorParent.cpp:658
#11 0x7e66fd88 in DispatchToMethod<mozilla::layers::CompositorParent, void (mozilla::layers::CompositorParent::*)()> (method=
    (void (mozilla::layers::CompositorParent::*)(mozilla::layers::CompositorParent * const)) 0x7e6669b7 <mozilla::layers::CompositorParent::Composite()>, obj=<optimized out>, arg=...)
    at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/tuple.h:383
#12 RunnableMethod<mozilla::layers::CompositorParent, void (mozilla::layers::CompositorParent::*)(), Tuple0>::Run (this=<optimized out>)
---Type <return> to continue, or q <return> to quit---
    at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/task.h:307
#13 0x7e2e5bc2 in MessageLoop::RunTask (this=0x881fdcc0, task=0x89bb7120) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:344
#14 0x7e2e84c4 in MessageLoop::DeferOrRunPendingTask (this=<optimized out>, pending_task=...) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:352
#15 0x7e2e9bf6 in DoWork (this=<optimized out>) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:430
#16 MessageLoop::DoWork (this=0x881fdcc0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:409
#17 0x7e2e7f58 in base::MessagePumpDefault::Run (this=0x87dc4d80, delegate=0x881fdcc0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_pump_default.cc:34
#18 0x7e2e80da in MessageLoop::RunInternal (this=0x881fdcc0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:226
#19 0x7e2e811a in RunHandler (this=0x881fdcc0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:219
#20 MessageLoop::Run (this=0x881fdcc0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/message_loop.cc:193
#21 0x7e2ef5d0 in base::Thread::ThreadMain (this=0x87ff18b0) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/thread.cc:162
#22 0x7e2dc770 in ThreadFunc (closure=<optimized out>) at /Users/snorp/source/gecko-dev/ipc/chromium/src/base/platform_thread_posix.cc:39
#23 0x40102174 in __thread_entry () from /Users/snorp/source/jimdb-arm/lib/00850937d791b9ee/system/lib/libc.so
#24 0x4010230c in pthread_create () from /Users/snorp/source/jimdb-arm/lib/00850937d791b9ee/system/lib/libc.so
#25 0x00000000 in ?? ()

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like it was caused by bug 971914. I'd guess we don't have ARB_TEXTURE_RECTANGLE on ES?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

err...TEXTURE_RECTANGLE_ARB. And no, that isn't a thing on ES2. Patch coming.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Wait, in another place we specifically use this with GLES2...so now I'm confused.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't try to use GL_TEXTURE_RECTANGLE_ARB on ES2

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c963fa4683b

Comment 7

[Ed Morley [:emorley]]

Push backed out:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=b9f2eb47b6f5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/731a5c2dc6dd