985536 - Go back to allowing "optional any"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a partial backout of bug 970764.

The spec end is a bit in flux, but the current proposal is at http://lists.w3.org/Archives/Public/public-script-coord/2014JanMar/0176.html

Here's what I plan to implement for now, pending the spec getting sorted out:

1)  Support both "any" and "optional any".
2)  Treat "optional any" with no default value provided as having a default
    value of "undefined".

This means we won't be able to distinguish between "not passed" and "undefined" for "optional any", but that's OK.  This will also keep our pre-bug 970764 behavior of throwing if non-optional "any" is not passed.  That seems safer pending the spec getting sorted out.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Need to track this on 30 to make sure we fix it there.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Go back to allowing optional any with no default value in WebIDL, but treat it as having a default value of undefined.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/501baeb3a034 and a test bustage fix in https://hg.mozilla.org/integration/mozilla-inbound/rev/b44ac78a0298

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for Aurora

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8401682 [details] [diff] [review]
Patch for Aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 970764 
User impact if declined: Some sites might start to depend on the behavior we
   have on Aurora right now, which we don't want.
Testing completed (on m-c, etc.): Passes tests.
Risk to taking this patch (and alternatives if risky): Low risk, I believe.
String or IDL/UUID changes made by this patch:  None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/501baeb3a034
https://hg.mozilla.org/mozilla-central/rev/b44ac78a0298

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/81e476d9599c