98558 - Composer-only: Drag-selecting in a table cell should change to "Cell Selection" mode when table cell boundary is crossed.

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Charles Manske]

Lots of feedback from users indicates that the compromise we made for selecting
table cells is not acceptable (e.g., see bug 98537). 
We should support standard table cell selection behavior, but only in Composer.
When a user drags the selection from one cell to another, we should snap into
selecting the entire cell where selection started, and continue to select only
cells as user continues to drag across other cells.
The first part of this task should be fixed by mjudge (the initial change to 
cell-selection mode when first cell boundary is crossed.)
The rest of the table-selection behavior (selecting blocks of cells, rows, 
columns) is owned by cmanske. He will be sure this still works after initial
problem is solved.

Comment 1

[Charles Manske]

This is an important issues and needs some attention

Comment 2

[mjudge]

i am looking at the code to see how hard it would be to turn it back on.

Comment 3

[mjudge]

will try to get to this soonest

Comment 4

[mjudge]

i believe this is a dup of a 9.7 bug of mine. when I see it i will dup it

Comment 5

[Charles Manske]

Attachment: Patch from mjudge: 1st attempt

Comment 6

[Charles Manske]

Starting with Mike's patch, I've fixed some problems and I'm completing this
work.

Comment 7

[Charles Manske]

Attachment: Complete Fix - v1

Fixes some problems in 1st patch and finishes changes need to make it all work.

Comment 8

[mjudge]

Comment on attachment 73534 [details] [diff] [review]
Complete Fix - v1

r=mjudge

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 73534 [details] [diff] [review]
Complete Fix - v1

sr=dveditz

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 73534 [details] [diff] [review]
Complete Fix - v1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Charles Manske]

checked in

Comment 12

[Terri Preston]

Verified fixed win xp trunk build 2002061808, Mac OS X trunk build 2002061808
and Linux trunk build 2002061808

Comment 13

[Ben Hutchings]

This doesn't work for header (<TH>) cells. Whole-cell selection isn't triggered
unless the starting cell is a normal (<TD>) cell and until the cursor moves into
another normal cell.
Observed in Mozilla 1.2.1 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB;
rv:1.2.1) Gecko/20021130).