Closed Bug 98558 Opened 25 years ago Closed 24 years ago

Composer-only: Drag-selecting in a table cell should change to "Cell Selection" mode when table cell boundary is crossed.

Categories

(Core :: DOM: Selection, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla1.0

People

(Reporter: cmanske, Assigned: cmanske)

References

(Blocks 1 open bug)

Details

(Keywords: topembed+, Whiteboard: QAHP, EDITORBASE+)

Attachments

(1 file, 1 obsolete file)

Lots of feedback from users indicates that the compromise we made for selecting table cells is not acceptable (e.g., see bug 98537). We should support standard table cell selection behavior, but only in Composer. When a user drags the selection from one cell to another, we should snap into selecting the entire cell where selection started, and continue to select only cells as user continues to drag across other cells. The first part of this task should be fixed by mjudge (the initial change to cell-selection mode when first cell boundary is crossed.) The rest of the table-selection behavior (selecting blocks of cells, rows, columns) is owned by cmanske. He will be sure this still works after initial problem is solved.
Blocks: 98537
Blocks: 97633
Blocks: 97632
This is an important issues and needs some attention
Whiteboard: QAHP, EDITORBASE
i am looking at the code to see how hard it would be to turn it back on.
Status: NEW → ASSIGNED
will try to get to this soonest
i believe this is a dup of a 9.7 bug of mine. when I see it i will dup it
Target Milestone: --- → mozilla0.9.7
Attached patch Patch from mjudge: 1st attempt (obsolete) — — Splinter Review
Whiteboard: QAHP, EDITORBASE → QAHP, EDITORBASE+
Keywords: nsbeta1+
Keywords: topembed+
Target Milestone: mozilla0.9.7 → mozilla1.0
Starting with Mike's patch, I've fixed some problems and I'm completing this work.
Assignee: mjudge → cmanske
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Fixes some problems in 1st patch and finishes changes need to make it all work.
Attachment #62167 - Attachment is obsolete: true
OS: Windows NT → All
Keywords: patch, review
Whiteboard: QAHP, EDITORBASE+ → QAHP, EDITORBASE+, FIX IN HAND, need r=,sr=
Comment on attachment 73534 [details] [diff] [review] Complete Fix - v1 r=mjudge
Attachment #73534 - Flags: review+
Whiteboard: QAHP, EDITORBASE+, FIX IN HAND, need r=,sr= → QAHP, EDITORBASE+, FIX IN HAND, need sr=
Comment on attachment 73534 [details] [diff] [review] Complete Fix - v1 sr=dveditz
Attachment #73534 - Flags: superreview+
Whiteboard: QAHP, EDITORBASE+, FIX IN HAND, need sr= → QAHP, EDITORBASE+, FIX IN HAND, reviewed
Comment on attachment 73534 [details] [diff] [review] Complete Fix - v1 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73534 - Flags: approval+
Whiteboard: QAHP, EDITORBASE+, FIX IN HAND, reviewed → QAHP, EDITORBASE+, FIX IN HAND, approved
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Keywords: patch, review
Whiteboard: QAHP, EDITORBASE+, FIX IN HAND, approved → QAHP, EDITORBASE+
Verified fixed win xp trunk build 2002061808, Mac OS X trunk build 2002061808 and Linux trunk build 2002061808
Status: RESOLVED → VERIFIED
This doesn't work for header (<TH>) cells. Whole-cell selection isn't triggered unless the starting cell is a normal (<TD>) cell and until the cursor moves into another normal cell. Observed in Mozilla 1.2.1 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.2.1) Gecko/20021130).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: