985676 - FF 28 config change for yahoo

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[abhinavn]

Attachment: repack_config_changes_for_yahoo.diff

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.149 Safari/537.36

Steps to reproduce:

Patch diff attached. If the attachment does not go through (as it's too large), a link to download the patch has been mailed to [e-mail] and [e-mail]

Comment 1

[Mike Connor [:mconnor]]

Firefox 28 has already been released, so it's a little late to submit changes for those builds.  We can get these landed for Firefox 29 (and any 28.0.1 point releases).

From looking at the patch, it appears this is changing all of the in-product URLs to use SSL?  That's great, but unfortunately this patch will no longer apply as we've bumped all of the identifiers to reflect the version (Fx28), and the same-line changes won't merge cleanly.  Can you regenerate this diff against current tip using what (I hope) is the same script?

Comment 2

[abhinavn]

Attachment: repack_config_changes_for_yahoo.diff

Merged with the string changes done by Mozilla + some additional https changes

Comment 3

[abhinavn]

Attachment: repack_config_changes_for_yahoo.diff.2

I had to do more changes after the commit that produced the previous diff, so I think this is a diff on the first diff, in some sense. I wasn't sure how to produce a consolidated diff, so the two attached diffs, together, should capture all the changes.

Comment 4

[Mike Connor [:mconnor]]

local sanity checks look good to me.  It might be worth making a script for applying toolbar updates globally like we have for the version bumps.


Checked in:
https://hg.mozilla.org/build/partner-repacks/rev/4ab9cee9ee38
https://hg.mozilla.org/build/partner-repacks/rev/51b961d5894a

Rail, as discussed, can you pop out a new set of builds when you get a chance?