Closed
Bug 985680
Opened 12 years ago
Closed 12 years ago
[Camera][Mozilla][UX] 1.4 Video record active button style not to spec
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect, P1)
Tracking
(b2g-v1.4 verified, b2g-v2.0 verified)
VERIFIED
FIXED
1.4 S5 (11apr)
People
(Reporter: amylee, Assigned: wilsonpage)
References
Details
(Whiteboard: ux-tracking, visual design, jian [fxos:media])
Attachments
(2 files)
|
472.57 KB,
image/png
|
Details | |
|
46 bytes,
text/x-github-pull-request
|
dmarcos
:
review+
amylee
:
ui-review+
tif
:
ui-review+
|
Details | Review |
Video_Record_Highlight_State.png
The highlight state (red) should fill entire circle. See attached spec.
Thanks!
|
Reporter | |
Comment 1•12 years ago
|
||
(In reply to Amy from comment #0)
> Created attachment 8393760 [details]
> Video_Record_Highlight_State.png
>
> The highlight state (red) should fill entire circle. See attached spec.
>
> Thanks!
One more thing:
The on press animation should be the same as for camera (i.e circle expands and changes into active state).
|
||
Comment 2•12 years ago
|
||
This looks like something I could probably manage to do, despite not knowing a whooole lot about the new camera code.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
|
||
Updated•12 years ago
|
Summary: [Camera][Mozilla] 1.4 Video record active button style not to spec → [Camera][Mozilla][UX] 1.4 Video record active button style not to spec
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #8397918 -
Flags: ui-review?(amlee)
Attachment #8397918 -
Flags: review?(dmarcos)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: squibblyflabbetydoo → wilsonpage
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Attachment #8397918 -
Flags: ui-review?(amlee) → ui-review+
|
|
||
Updated•12 years ago
|
Attachment #8397918 -
Flags: review?(dmarcos) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Landed on 'master'
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Attachment #8397918 -
Flags: ui-review?(tshakespeare)
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 8397918 [details] [review]
pull-request (master)
Patch works and camera/video button fill entirely during record/capture as per Amy's spec.
Attachment #8397918 -
Flags: ui-review?(tshakespeare) → ui-review+
|
||
Comment 8•12 years ago
|
||
Bulk edit for camera bugs.
If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.
This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
The bug is no longer reproduces
The highlight state (red) fills entire circle.
1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg
1.5 Environmental Variables:
Device: Buri Master
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg
You need to log in
before you can comment on or make changes to this bug.
Description
•