985720 - rename urlclassifier.download_block_table and urlclassifier.download_allow_table

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

+++ This bug was initially created as a clone of Bug #985623 +++

Because of the hotfix in bug 985627, these settings will be considered "user-set" and we can't change the defaults anymore once bug 985623 is fixed.

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3d94ebde9018

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8395780 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

This requires bug 985623. They must go together.

[Approval Request Comment]
Same as https://bugzilla.mozilla.org/show_bug.cgi?id=985623#c15

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

This was the try push: https://tbpl.mozilla.org/?tree=Try&rev=13b028f2db4d

Oranges look unrelated and different from the oranges on inbound.

Comment 5

[Bill Gianopoulos [:WG9s]]

The orange on inbound would seem to be caused by this patch neglecting to rename the preferences in all.js.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/0bebf48df01e to reopen the tree.

Comment 7

[Bill Gianopoulos [:WG9s]]

OIC the patch attached here includes that change but what added on inbound did not.

Comment 8

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

Comment 9

[[:mmc] Monica Chew (no longer reading bugmail)]

(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> OIC the patch attached here includes that change but what added on inbound
> did not.

Yeah, that was idiot me not resolving merge conflicts correctly when I imported my patch to m-i :( Thanks for catching that.

Comment 10

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8396101 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

[Approval Request Comment]
See comment https://bugzilla.mozilla.org/show_bug.cgi?id=985623#c15

Comment 11

[[:mmc] Monica Chew (no longer reading bugmail)]

Marking checkin-needed since I busted the tree

Comment 12

[Carsten Book [:Tomcat]]

checkedin as https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf44a1d5a59

Comment 13

[Carsten Book [:Tomcat]]

ups was to fast with closing as fixed since this landed only on m-i so far, sorry

Comment 14

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: rename-prefs

patch for mozilla-beta
Try: https://tbpl.mozilla.org/?tree=Try&rev=507c17e38082

Comment 15

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8396101 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

Patch applies cleanly to aurora but not beta.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9cf44a1d5a59

Comment 17

[[:mmc] Monica Chew (no longer reading bugmail)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/72b5814f3a3b
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/10904f84c309