Closed Bug 985720 Opened 8 years ago Closed 8 years ago

rename urlclassifier.download_block_table and urlclassifier.download_allow_table

Categories

(Core :: DOM: Security, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox29 --- disabled
firefox30 --- fixed
firefox31 --- fixed

People

(Reporter: mmc, Assigned: mmc)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #985623 +++

Because of the hotfix in bug 985627, these settings will be considered "user-set" and we can't change the defaults anymore once bug 985623 is fixed.
Assignee: nobody → mmc
Status: NEW → ASSIGNED
Attachment #8395780 - Flags: review?(gpascutto)
Attachment #8395780 - Flags: review?(gpascutto) → review+
Comment on attachment 8395780 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

This requires bug 985623. They must go together.

[Approval Request Comment]
Same as https://bugzilla.mozilla.org/show_bug.cgi?id=985623#c15
Attachment #8395780 - Flags: approval-mozilla-beta?
Attachment #8395780 - Flags: approval-mozilla-aurora?
This was the try push: https://tbpl.mozilla.org/?tree=Try&rev=13b028f2db4d

Oranges look unrelated and different from the oranges on inbound.
The orange on inbound would seem to be caused by this patch neglecting to rename the preferences in all.js.
Flags: needinfo?(mmc)
OIC the patch attached here includes that change but what added on inbound did not.
Flags: needinfo?(mmc)
(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> OIC the patch attached here includes that change but what added on inbound
> did not.

Yeah, that was idiot me not resolving merge conflicts correctly when I imported my patch to m-i :( Thanks for catching that.
Comment on attachment 8396101 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

[Approval Request Comment]
See comment https://bugzilla.mozilla.org/show_bug.cgi?id=985623#c15
Attachment #8396101 - Flags: review+
Attachment #8396101 - Flags: approval-mozilla-beta?
Attachment #8396101 - Flags: approval-mozilla-aurora?
Marking checkin-needed since I busted the tree
Keywords: checkin-needed
Attachment #8395780 - Attachment is obsolete: true
Attachment #8395780 - Flags: approval-mozilla-beta?
Attachment #8395780 - Flags: approval-mozilla-aurora?
checkedin as https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf44a1d5a59
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
ups was to fast with closing as fixed since this landed only on m-i so far, sorry
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file rename-prefs
patch for mozilla-beta
Try: https://tbpl.mozilla.org/?tree=Try&rev=507c17e38082
Attachment #8396681 - Flags: approval-mozilla-beta?
Comment on attachment 8396101 [details] [diff] [review]
Rename urlclassifier.download_block_table and urlclassifier.download_allow_table (

Patch applies cleanly to aurora but not beta.
Attachment #8396101 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/9cf44a1d5a59
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Attachment #8396101 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8396681 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.