Closed Bug 985795 Opened 7 years ago Closed 7 years ago

Contacts unit test fails due to missing utils.misc.vcardToContact function

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S4 (28mar)

People

(Reporter: qdot, Assigned: qdot)

References

Details

(Whiteboard: [systemsfe] [p=2] )

Attachments

(1 file)

When run locally during my tests to get linux OOP working, I kept hitting an error in contacts details_test.js, Render Contact suite setup function. It's missing the utils.misc.vcardToContact function.
Assigning to Jose since it looks like this came in with bug 935045. No idea why it's not failing everywhere.
Attachment #8393903 - Flags: review?(jmcf)
Whiteboard: [systemsfe] [p=2]
Target Milestone: --- → 1.4 S3 (14mar)
Target Milestone: 1.4 S3 (14mar) → 1.4 S4 (28mar)
Comment on attachment 8393903 [details] [review]
Patch 1 (v1) - Only patch single function of utils.misc that are needed for unit tests, bring in rest of object

thanks for the fix!
Attachment #8393903 - Flags: review?(jmcf) → review+
landed in master:

https://github.com/mozilla-b2g/gaia/commit/76588a15c559aaf55b0e2e47798df490b544b036
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.